From dc7bf89648e27a3be21de8b2f266f04d0d19861c Mon Sep 17 00:00:00 2001
From: Sascha Brawer <sascha@brawer.ch>
Date: Fri, 17 Feb 2017 14:19:54 +0100
Subject: [PATCH] [feaLib] Test compiling zero values for SinglePos in vertical
 context

https://github.com/fonttools/fonttools/issues/633
---
 Tests/feaLib/builder_test.py                  |  2 +-
 .../data/ZeroValue_SinglePos_horizontal.fea   |  8 ++++
 ...ttx => ZeroValue_SinglePos_horizontal.ttx} |  2 +-
 ...s.fea => ZeroValue_SinglePos_vertical.fea} |  6 ++-
 .../data/ZeroValue_SinglePos_vertical.ttx     | 47 +++++++++++++++++++
 5 files changed, 61 insertions(+), 4 deletions(-)
 create mode 100644 Tests/feaLib/data/ZeroValue_SinglePos_horizontal.fea
 rename Tests/feaLib/data/{ZeroValue_SinglePos.ttx => ZeroValue_SinglePos_horizontal.ttx} (97%)
 rename Tests/feaLib/data/{ZeroValue_SinglePos.fea => ZeroValue_SinglePos_vertical.fea} (76%)
 create mode 100644 Tests/feaLib/data/ZeroValue_SinglePos_vertical.ttx

diff --git a/Tests/feaLib/builder_test.py b/Tests/feaLib/builder_test.py
index 0b6bebe30..15ec503bb 100644
--- a/Tests/feaLib/builder_test.py
+++ b/Tests/feaLib/builder_test.py
@@ -65,7 +65,7 @@ class BuilderTest(unittest.TestCase):
         bug453 bug457 bug463 bug501 bug502 bug504 bug505 bug506 bug509
         bug512 bug514 bug568 bug633
         name size size2 multiple_feature_blocks omitted_GlyphClassDef
-        ZeroValue_SinglePos
+        ZeroValue_SinglePos_horizontal ZeroValue_SinglePos_vertical
         ZeroValue_PairPos_horizontal ZeroValue_PairPos_vertical
         ZeroValue_ChainSinglePos_horizontal ZeroValue_ChainSinglePos_vertical
     """.split()
diff --git a/Tests/feaLib/data/ZeroValue_SinglePos_horizontal.fea b/Tests/feaLib/data/ZeroValue_SinglePos_horizontal.fea
new file mode 100644
index 000000000..44fe683d3
--- /dev/null
+++ b/Tests/feaLib/data/ZeroValue_SinglePos_horizontal.fea
@@ -0,0 +1,8 @@
+# For SinglePos statements, zeroes should get compiled to ValueRecord format 0.
+# https://github.com/fonttools/fonttools/issues/633
+
+# Zero value in a horizontal context.
+feature kern {
+    pos A 0;          # format A
+    pos B <0 0 0 0>;  # format B
+} kern;
diff --git a/Tests/feaLib/data/ZeroValue_SinglePos.ttx b/Tests/feaLib/data/ZeroValue_SinglePos_horizontal.ttx
similarity index 97%
rename from Tests/feaLib/data/ZeroValue_SinglePos.ttx
rename to Tests/feaLib/data/ZeroValue_SinglePos_horizontal.ttx
index 3bdc91867..d5fe6394e 100644
--- a/Tests/feaLib/data/ZeroValue_SinglePos.ttx
+++ b/Tests/feaLib/data/ZeroValue_SinglePos_horizontal.ttx
@@ -20,7 +20,7 @@
     <FeatureList>
       <!-- FeatureCount=1 -->
       <FeatureRecord index="0">
-        <FeatureTag value="TEST"/>
+        <FeatureTag value="kern"/>
         <Feature>
           <!-- LookupCount=1 -->
           <LookupListIndex index="0" value="0"/>
diff --git a/Tests/feaLib/data/ZeroValue_SinglePos.fea b/Tests/feaLib/data/ZeroValue_SinglePos_vertical.fea
similarity index 76%
rename from Tests/feaLib/data/ZeroValue_SinglePos.fea
rename to Tests/feaLib/data/ZeroValue_SinglePos_vertical.fea
index 20acff194..3ee9a1bf5 100644
--- a/Tests/feaLib/data/ZeroValue_SinglePos.fea
+++ b/Tests/feaLib/data/ZeroValue_SinglePos_vertical.fea
@@ -1,6 +1,8 @@
 # For SinglePos statements, zeroes should get compiled to ValueRecord format 0.
 # https://github.com/fonttools/fonttools/issues/633
-feature TEST {
+
+# Zero value in a vertical context.
+feature vkrn {
     pos A 0;          # format A
     pos B <0 0 0 0>;  # format B
-} TEST;
+} vkrn;
diff --git a/Tests/feaLib/data/ZeroValue_SinglePos_vertical.ttx b/Tests/feaLib/data/ZeroValue_SinglePos_vertical.ttx
new file mode 100644
index 000000000..3879c360c
--- /dev/null
+++ b/Tests/feaLib/data/ZeroValue_SinglePos_vertical.ttx
@@ -0,0 +1,47 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ttFont sfntVersion="true" ttLibVersion="3.0">
+
+  <GPOS>
+    <Version value="0x00010000"/>
+    <ScriptList>
+      <!-- ScriptCount=1 -->
+      <ScriptRecord index="0">
+        <ScriptTag value="DFLT"/>
+        <Script>
+          <DefaultLangSys>
+            <ReqFeatureIndex value="65535"/>
+            <!-- FeatureCount=1 -->
+            <FeatureIndex index="0" value="0"/>
+          </DefaultLangSys>
+          <!-- LangSysCount=0 -->
+        </Script>
+      </ScriptRecord>
+    </ScriptList>
+    <FeatureList>
+      <!-- FeatureCount=1 -->
+      <FeatureRecord index="0">
+        <FeatureTag value="vkrn"/>
+        <Feature>
+          <!-- LookupCount=1 -->
+          <LookupListIndex index="0" value="0"/>
+        </Feature>
+      </FeatureRecord>
+    </FeatureList>
+    <LookupList>
+      <!-- LookupCount=1 -->
+      <Lookup index="0">
+        <LookupType value="1"/>
+        <LookupFlag value="0"/>
+        <!-- SubTableCount=1 -->
+        <SinglePos index="0" Format="1">
+          <Coverage>
+            <Glyph value="A"/>
+            <Glyph value="B"/>
+          </Coverage>
+          <ValueFormat value="0"/>
+        </SinglePos>
+      </Lookup>
+    </LookupList>
+  </GPOS>
+
+</ttFont>