shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

More types, correct stale comment

Browse Source
This commit is contained in:
Nikolaus Waxweiler 2020-09-16 09:52:46 +01:00
parent fa32cf2fed
commit e1c9710272
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Lib/fontTools/misc/plistlib.py
View File

@ -5,6 +5,7 @@ from typing import (
Any, Any,
Callable, Callable,
Dict, Dict,
List,
Mapping, Mapping,
MutableMapping, MutableMapping,
Optional, Optional,
@ -187,7 +188,7 @@ class PlistTarget:
use_builtin_types: Optional[bool] = None, use_builtin_types: Optional[bool] = None,
dict_type: Type[MutableMapping[str, Any]] = dict, dict_type: Type[MutableMapping[str, Any]] = dict,
) -> None: ) -> None:
self.stack = [] self.stack: List[PlistEncodable] = []
self.current_key = None self.current_key = None
self.root: Optional[PlistEncodable] = None self.root: Optional[PlistEncodable] = None
if use_builtin_types is None: if use_builtin_types is None:
@ -203,7 +204,7 @@ class PlistTarget:
self._dict_type = dict_type self._dict_type = dict_type
def start(self, tag: str, attrib: Mapping[str, str]) -> None: def start(self, tag: str, attrib: Mapping[str, str]) -> None:
self._data = [] self._data: List[str] = []
handler = _TARGET_START_HANDLERS.get(tag) handler = _TARGET_START_HANDLERS.get(tag)
if handler is not None: if handler is not None:
handler(self) handler(self)
@ -412,9 +413,11 @@ def _string_or_data_element(raw_bytes: bytes, ctx: SimpleNamespace) -> etree.Ele
return _string_element(string, ctx) return _string_element(string, ctx)
# The following is to pacify type checkers. At the time of this writing, neither # The following is probably not entirely correct. The signature should take `Any`
# mypy nor Pyright can deal with singledispatch properly. Mypy additionally # and return `NoReturn`. At the time of this writing, neither mypy nor Pyright
# complains about a single overload when there should be more (?) so silence it. # can deal with singledispatch properly and will apply the signature of the base
# function to all others. Being slightly dishonest makes it type-check and return
# usable typing information for the optimistic case.
@singledispatch @singledispatch
def _make_element(value: PlistEncodable, ctx: SimpleNamespace) -> etree.Element: def _make_element(value: PlistEncodable, ctx: SimpleNamespace) -> etree.Element:
raise TypeError("unsupported type: %s" % type(value)) raise TypeError("unsupported type: %s" % type(value))