From e2d9919524c2d65e7d33a0fb42f7a921986256f4 Mon Sep 17 00:00:00 2001 From: Eric Muller Date: Tue, 1 Jun 2021 07:16:53 -0700 Subject: [PATCH] Address pull request comments --- Lib/fontTools/ttLib/tables/_p_o_s_t.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Lib/fontTools/ttLib/tables/_p_o_s_t.py b/Lib/fontTools/ttLib/tables/_p_o_s_t.py index 433383dc4..9bd49444e 100644 --- a/Lib/fontTools/ttLib/tables/_p_o_s_t.py +++ b/Lib/fontTools/ttLib/tables/_p_o_s_t.py @@ -87,7 +87,7 @@ class table__p_o_s_t(DefaultTable.DefaultTable): indices.frombytes(data[:2*numGlyphs]) if sys.byteorder != "big": indices.byteswap() data = data[2*numGlyphs:] - maxIndex = max(indices[:numGlyphs]) + maxIndex = max(indices) self.extraNames = extraNames = unpackPStrings(data, maxIndex-257) self.glyphOrder = glyphOrder = [""] * int(ttFont['maxp'].numGlyphs) for glyphID in range(numGlyphs): @@ -264,23 +264,23 @@ def unpackPStrings(data, n): dataLen = len(data) for _ in range(n): - if (dataLen <= index): + if dataLen <= index: length = 0 else: length = byteord(data[index]) index += 1 - if (dataLen <= index + length - 1): + if dataLen <= index + length - 1: name = "" else: name = tostr(data[index:index+length], encoding="latin1") strings.append (name) index += length - if (index < dataLen): + if index < dataLen: log.warning("%d extra bytes in post.stringData array", dataLen - index) - elif (dataLen < index): + elif dataLen < index: log.warning("not enough data in post.stringData array") return strings