From ee244406ee12cdcfe451c28e665b75fe08cf9057 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micka=C3=ABl=20Schoentgen?= Date: Tue, 25 Sep 2018 23:04:26 +0200 Subject: [PATCH] Fix several ResourceWarning: unclosed file in subset --- Lib/fontTools/subset/__init__.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/Lib/fontTools/subset/__init__.py b/Lib/fontTools/subset/__init__.py index 989c98be3..4450e18dc 100644 --- a/Lib/fontTools/subset/__init__.py +++ b/Lib/fontTools/subset/__init__.py @@ -3253,7 +3253,8 @@ def main(args=None): text += g[7:] continue if g.startswith('--text-file='): - text += open(g[12:], encoding='utf-8').read().replace('\n', '') + with open(g[12:], encoding='utf-8') as f: + text += f.read().replace('\n', '') continue if g.startswith('--unicodes='): if g[11:] == '*': @@ -3262,15 +3263,17 @@ def main(args=None): unicodes.extend(parse_unicodes(g[11:])) continue if g.startswith('--unicodes-file='): - for line in open(g[16:]).readlines(): - unicodes.extend(parse_unicodes(line.split('#')[0])) + with open(g[16:]) as f: + for line in f.readlines(): + unicodes.extend(parse_unicodes(line.split('#')[0])) continue if g.startswith('--gids='): gids.extend(parse_gids(g[7:])) continue if g.startswith('--gids-file='): - for line in open(g[12:]).readlines(): - gids.extend(parse_gids(line.split('#')[0])) + with open(g[12:]) as f: + for line in f.readlines(): + gids.extend(parse_gids(line.split('#')[0])) continue if g.startswith('--glyphs='): if g[9:] == '*': @@ -3279,8 +3282,9 @@ def main(args=None): glyphs.extend(parse_glyphs(g[9:])) continue if g.startswith('--glyphs-file='): - for line in open(g[14:]).readlines(): - glyphs.extend(parse_glyphs(line.split('#')[0])) + with open(g[14:]) as f: + for line in f.readlines(): + glyphs.extend(parse_glyphs(line.split('#')[0])) continue glyphs.append(g)