From fae87446a832f0f6555d760caad419a18fc6d280 Mon Sep 17 00:00:00 2001
From: Khaled Hosny <khaled@aliftype.com>
Date: Sun, 31 Mar 2024 01:10:24 +0200
Subject: [PATCH] Add some basic tests for reorderGlyphs

---
 Tests/ttLib/data/Test-Regular.ttf | Bin 0 -> 1560 bytes
 Tests/ttLib/reorderGlyphs_test.py |  77 ++++++++++++++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 Tests/ttLib/data/Test-Regular.ttf
 create mode 100644 Tests/ttLib/reorderGlyphs_test.py

diff --git a/Tests/ttLib/data/Test-Regular.ttf b/Tests/ttLib/data/Test-Regular.ttf
new file mode 100644
index 0000000000000000000000000000000000000000..db03587bb66275b15099fed377ae6bf6f2f4fe36
GIT binary patch
literal 1560
zcmcgsO-vI(6#iznEm)&M0>R)<x-E!5V1Zghg@Y>=feO`1K~%K1g{l;2#rSj5gBPR5
zn+fs2sqvr*F`mRkj2<|dc=w_n<mAPlgNd%+%vNoPdSrHY=6&zY`<wS>ApoqxRp^Lx
zM7uhP$Z?f%E$xi-MQ3Brh5=`oIN2HPH}9KInu%wLhx?-b=FyLdAyAp)R3a0f6u0n@
z_!Mz?bnNnov+Bnj={Njdrc?1`?b#gdYmLM$X);`4@sU`{YtosiOU??MAWjqK#wHSR
zcg!7QNb|(wnfRqiM>i-FGsK?pcqUaAZG23B56CN<oH#$_%DNr_j;EC0h8riWRxz!6
z7+?ujq6!;Ohizy=I}R`lqukId1HlqsFi^)eQ0WW$xYkwLGqL0b>k4uoB{q+YAT>)U
z_U#M=#q^ICqWx3eNGA7rjiiw`uIKZnnKYAzVdl-mUQT8{6v~f;JPZ2b_gFR?@xN-V
z@<+1SE2cNuX4D!XqrJwP_J*#J=KH<e@Ed$(HPC`C<|2oHhK<Yx4h7Y88q4>{2-J7?
zL;C&6HEmy@>x(jqciSsp+w0oTzfT>ERFhn)kc$OYcF@MlGBZ|v(Q3tl@;W4@RrJNK
zbvU$MaR*M6YB$ub9(xtTXvVkVt)x|(|Kj!c4D@0i9?a+->4WFM{A>^6vnD&xqq3JL
zAT=vE%hRi1@mjgMQA)YST|>Bn8OtKigT07L+Inj}x8|(4ZI2Rrlww3$ajYO;-cg&@
zu$suGb?jh=*tCQ84i{)As*x+uF7CKlpv#Kvlq);ENZ}$iLzuugrf4CBQCz?nBg^sb
zY)7Md_Mjg<7(g%f@RK^fG#ZxZEVU@3Dz+IT%HcfDD36{ZAOE*o=q>9WYxTF$qE4s=
zwb;aazZqMwmAAhh4a~vM9Ga*X;CTgk!*;SJyRe(NwDIrIf&I*;lYfaWbTi8^4l>6+
zL~w|)M{$I?$C&#dj<R~ka9sYiRIS`R+j@wOQ1}SztF9?4E2Q*XDmPA^y-!dk;}@z6
zWKV#aUSe{subd^dj$FA*qV<eZ@R6PKPalayX7aZW4K7yQNe$_RJ;A41Ar%jKLhbnD
Ji$d}^egf0M-3$N#

literal 0
HcmV?d00001

diff --git a/Tests/ttLib/reorderGlyphs_test.py b/Tests/ttLib/reorderGlyphs_test.py
new file mode 100644
index 000000000..cfda2d285
--- /dev/null
+++ b/Tests/ttLib/reorderGlyphs_test.py
@@ -0,0 +1,77 @@
+import pytest
+
+from pathlib import Path
+from fontTools.ttLib import TTFont
+from fontTools.ttLib.reorderGlyphs import reorderGlyphs
+
+DATA_DIR = Path(__file__).parent / "data"
+
+
+@pytest.mark.parametrize("lazy", [True, False, None])
+def test_reorder_glyphs(lazy):
+    font_path = DATA_DIR / "Test-Regular.ttf"
+    font = TTFont(str(font_path), lazy=lazy)
+    old_coverage1 = list(
+        font["GSUB"].table.LookupList.Lookup[0].SubTable[0].Coverage[0].glyphs
+    )
+    old_coverage2 = list(
+        font["GPOS"].table.LookupList.Lookup[0].SubTable[0].Coverage.glyphs
+    )
+
+    ga = font.getGlyphOrder()
+    ga = [ga[0]] + list(reversed(ga[1:]))
+    reorderGlyphs(font, ga)
+
+    new_coverage1 = list(
+        font["GSUB"].table.LookupList.Lookup[0].SubTable[0].Coverage[0].glyphs
+    )
+    new_coverage2 = list(
+        font["GPOS"].table.LookupList.Lookup[0].SubTable[0].Coverage.glyphs
+    )
+
+    assert list(reversed(old_coverage1)) == new_coverage1
+    assert list(reversed(old_coverage2)) == new_coverage2
+
+
+def test_ttfont_reorder_glyphs():
+    font_path = DATA_DIR / "Test-Regular.ttf"
+    font = TTFont(str(font_path))
+    ga = font.getGlyphOrder()
+    ga = [ga[0]] + list(reversed(ga[1:]))
+
+    old_coverage1 = list(
+        font["GSUB"].table.LookupList.Lookup[0].SubTable[0].Coverage[0].glyphs
+    )
+    old_coverage2 = list(
+        font["GPOS"].table.LookupList.Lookup[0].SubTable[0].Coverage.glyphs
+    )
+
+    font.reorderGlyphs(ga)
+
+    new_coverage1 = list(
+        font["GSUB"].table.LookupList.Lookup[0].SubTable[0].Coverage[0].glyphs
+    )
+    new_coverage2 = list(
+        font["GPOS"].table.LookupList.Lookup[0].SubTable[0].Coverage.glyphs
+    )
+
+    assert list(reversed(old_coverage1)) == new_coverage1
+    assert list(reversed(old_coverage2)) == new_coverage2
+
+
+def test_reorder_glyphs_bad_length(caplog):
+    font_path = DATA_DIR / "Test-Regular.ttf"
+    font = TTFont(str(font_path))
+    with pytest.raises(ValueError) as ex:
+        reorderGlyphs(font, ["A"])
+    assert "New glyph order contains 1 glyphs" in str(ex.value)
+
+
+def test_reorder_glyphs_bad_set(caplog):
+    font_path = DATA_DIR / "Test-Regular.ttf"
+    font = TTFont(str(font_path))
+    ga = list(font.getGlyphOrder()) + ["AA"]
+    ga.pop(1)
+    with pytest.raises(ValueError) as ex:
+        reorderGlyphs(font, ga)
+    assert "New glyph order does not contain the same set of glyphs" in str(ex.value)