[feaLib][test] No need to create temporary file (#764)

Loading features from file objects have been supported for a while
already.
This commit is contained in:
Khaled Hosny 2016-12-11 00:29:14 +02:00 committed by Sascha Brawer
parent cada4607fb
commit fbf896c969
2 changed files with 5 additions and 23 deletions

View File

@ -1,7 +1,8 @@
from __future__ import print_function, division, absolute_import
from __future__ import unicode_literals
from fontTools.misc.py23 import *
from fontTools.feaLib.builder import Builder, addOpenTypeFeatures
from fontTools.feaLib.builder import Builder, addOpenTypeFeatures, \
addOpenTypeFeaturesFromString
from fontTools.feaLib.builder import LigatureSubstBuilder
from fontTools.feaLib.error import FeatureLibError
from fontTools.ttLib import TTFont
@ -117,11 +118,8 @@ class BuilderTest(unittest.TestCase):
self.fail("TTX output is different from expected")
def build(self, featureFile):
path = self.temp_path(suffix=".fea")
with open(path, "w", encoding="utf-8") as outfile:
outfile.write(featureFile)
font = makeTTFont()
addOpenTypeFeatures(font, path)
addOpenTypeFeaturesFromString(font, featureFile)
return font
def check_feature_file(self, name):

View File

@ -5,9 +5,6 @@ from fontTools.feaLib.parser import Parser, SymbolTable
from fontTools.misc.py23 import *
import fontTools.feaLib.ast as ast
import os
import shutil
import sys
import tempfile
import unittest
@ -1263,22 +1260,9 @@ class ParserTest(unittest.TestCase):
doc = self.parse(";;;")
self.assertFalse(doc.statements)
def setUp(self):
self.tempdir = None
self.num_tempfiles = 0
def tearDown(self):
if self.tempdir:
shutil.rmtree(self.tempdir)
def parse(self, text):
if not self.tempdir:
self.tempdir = tempfile.mkdtemp()
self.num_tempfiles += 1
path = os.path.join(self.tempdir, "tmp%d.fea" % self.num_tempfiles)
with open(path, "w", encoding="utf-8") as outfile:
outfile.write(text)
return Parser(path).parse()
featurefile = UnicodeIO(text)
return Parser(featurefile).parse()
@staticmethod
def getpath(testfile):