shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1903 from anthrotype/remove-feature-variations

Browse Source 
subset: remove FeatureVariations, downgrade GSUB/GPOS to version 1 when empty
This commit is contained in:
Cosimo Lupo 2020-04-29 11:06:23 +01:00 committed by GitHub
commit fc10f74a19
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Lib/fontTools/subset/__init__.py
View File

@ -1631,11 +1631,11 @@ def prune_post_subset(self, font, options):
#if table.ScriptList and not table.ScriptList.ScriptRecord:
# table.ScriptList = None
if not table.FeatureList and hasattr(table, 'FeatureVariations'):
if hasattr(table, 'FeatureVariations'):
if not (table.FeatureList and table.FeatureVariations.FeatureVariationRecord):
table.FeatureVariations = None
if hasattr(table, 'FeatureVariations') and not table.FeatureVariations:
if table.Version == 0x00010001:
if not table.FeatureVariations and table.Version == 0x00010001:
table.Version = 0x00010000
return True

3
Tests/subset/subset_test.py
View File

@ -793,7 +793,8 @@ def test_subset_feature_variations_drop_all(featureVarsTestFont):
assert "rvrn" not in featureTags
assert glyphs == {".notdef", "f", "dollar"}
# all FeatureVariationRecords were dropped
assert not font["GSUB"].table.FeatureVariations.FeatureVariationRecord
assert font["GSUB"].table.FeatureVariations is None
assert font["GSUB"].table.Version == 0x00010000
# TODO test_subset_feature_variations_drop_from_end_empty_records