shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Light validation during write.

Browse Source 
git-svn-id: http://svn.robofab.com/branches/ufo3k@336 b5fa9d6c-a76f-4ffd-b3cb-f825fc41095c
This commit is contained in:
Tal Leming 2011-09-29 13:36:45 +00:00
parent 4afcd0f113
commit ff8428c052
1 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
Lib/ufoLib/__init__.py
View File

@ -742,8 +742,17 @@ class UFOWriter(object):
Write groups.plist. This method requires a Write groups.plist. This method requires a
dict of glyph groups as an argument. dict of glyph groups as an argument.
""" """
invalidFormatMessage = "The groups are not properly formatted."
if not isinstance(groups, dict): if not isinstance(groups, dict):
raise UFOLibError("The groups must be a dict or dict like object.") raise UFOLibError(invalidFormatMessage)
for groupName, glyphList in groups.items():
if not isinstance(groupName, basestring):
raise UFOLibError(invalidFormatMessage)
if not isinstance(glyphList, list):
raise UFOLibError(invalidFormatMessage)
for glyphName in glyphList:
if not isinstance(glyphName, basestring):
raise UFOLibError(invalidFormatMessage)
self._makeDirectory() self._makeDirectory()
path = os.path.join(self._path, GROUPS_FILENAME) path = os.path.join(self._path, GROUPS_FILENAME)
groupsNew = {} groupsNew = {}
@ -797,8 +806,20 @@ class UFOWriter(object):
Write kerning.plist. This method requires a Write kerning.plist. This method requires a
dict of kerning pairs as an argument. dict of kerning pairs as an argument.
""" """
invalidFormatMessage = "The kerning is not properly formatted."
if not isinstance(kerning, dict): if not isinstance(kerning, dict):
raise UFOLibError("The kerning must be a dict or dict like object.") raise UFOLibError(invalidFormatMessage)
for pair, value in kerning.items():
if not isinstance(pair, (list, tuple)):
raise UFOLibError(invalidFormatMessage)
if not len(pair) == 2:
raise UFOLibError(invalidFormatMessage)
if not isinstance(pair[0], basestring):
raise UFOLibError(invalidFormatMessage)
if not isinstance(pair[1], basestring):
raise UFOLibError(invalidFormatMessage)
if not isinstance(value, (int, float)):
raise UFOLibError(invalidFormatMessage)
self._makeDirectory() self._makeDirectory()
path = os.path.join(self._path, KERNING_FILENAME) path = os.path.join(self._path, KERNING_FILENAME)
kerningDict = {} kerningDict = {}
@ -837,6 +858,8 @@ class UFOWriter(object):
""" """
if self._formatVersion == 1: if self._formatVersion == 1:
raise UFOLibError("features.fea is not allowed in UFO Format Version 1.") raise UFOLibError("features.fea is not allowed in UFO Format Version 1.")
if not isinstance(features, basestring):
raise UFOLibError("The features are not text.")
self._makeDirectory() self._makeDirectory()
path = os.path.join(self._path, FEATURES_FILENAME) path = os.path.join(self._path, FEATURES_FILENAME)
writeFileAtomically(features, path) writeFileAtomically(features, path)