shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,742 Commits 1 Branch 0 Tags
Commit Graph

6436 Commits

Author SHA1 Message Date
Cosimo Lupo
b3ce0979cb
Merge pull request #3123 from fonttools/avar2-designspace 
[designspace] Add avar2 mapping support
 2023-06-08 12:58:51 +01:00
خالد حسني (Khaled Hosny)
9ad4a36309
Merge pull request #3130 from fonttools/fealib-ligcaret-variable 
[feaLib] Support variable ligature caret position
 2023-06-08 14:58:23 +03:00
Cosimo Lupo
dfec4abf6d
glyf: use 'round' parameter in _getCoordinatesAndControls 
as Behdad suggested in review
 2023-06-08 11:47:47 +01:00
Cosimo Lupo
5c0f05cc42
allow to pass 'round' parameter in ttGlyphPen, optimize for noRound 2023-06-08 11:41:07 +01:00
Cosimo Lupo
86777525a6
drop oncurve if it's impliable either before OR after rounding 
ofter the rounding gives us an opportunity to make an oncurve impliable, for points that were not equidistant become so after round, so why not take it!
 2023-06-07 18:13:58 +01:00
Cosimo Lupo
1ca554332c
_getCoordinatesAndControls: make sure coords are rounded toInt() as gvar expects 
ufo2ft will no longer send varLib already-rounded master glyf tables (to give it an opportunity to compute implied oncurves on the pre-rounded coords) so when retrieving coordinates off the glyf table in order to compute gvar deltas we have to round
 2023-06-07 18:05:48 +01:00
Cosimo Lupo
97e626b23e
ttGlyphPen: drop implied before rounding, allow not to round at all 
We want to be able to compute implied oncurves both before coordinates have been rounded to integer and afterwards.
Also when ufo2ft builds interpolatable master TTFs, we want to turn off the rounding so that varLib can call dropImpliedOnCurvePoints on the un-rounded coordinates, so we need an option to disable rounding the coordinates in the ttGlyphPens
 2023-06-07 17:55:56 +01:00
Cosimo Lupo
f7ca9f28ac
vector: add isclose method to compare vs another Vector using math.isclose 2023-06-07 17:50:33 +01:00
Cosimo Lupo
66ce7c0e0c
Merge pull request #3155 from fonttools/fix-drop-implied-oncurves 
fix a bug in dropImpliedOnCurvePoints
 2023-06-06 18:02:11 +01:00
Cosimo Lupo
0761508510
must update start = last + 1 in dropImpliedOnCurvePoints 
Fixes #3155
 2023-06-06 17:01:40 +01:00
Behdad Esfahbod
65598197c8 [subset] Remove quotation marks from command-line samples 
Those have confused Windows users before.

Fixes https://github.com/fonttools/fonttools/issues/3149
 2023-06-05 09:42:17 -06:00
Cosimo Lupo
5b93100616
also check endPtsOfContours in dropImpliedOnCurvePoints 
as per review https://github.com/fonttools/fonttools/pull/3147#discussion_r1214708207

Also, don't do same work multiple times when dropping points from flags/endPtsOfContours arrays since these are supposed to be the same for all interpolatable glyphs
 2023-06-05 12:11:17 +01:00
Behdad Esfahbod
d601646cf2 [varLib/avar2] Remove warning 
https://github.com/fonttools/fonttools/pull/3123#issuecomment-1573199305
 2023-06-02 12:51:25 -06:00
Cosimo Lupo
0690703b86
varLib: add --drop-implied-oncurves option 
For the test, I used the Tests/varLib/data/Build.designspace as starting point, modified the 'a' glyph so that 1 on-curve point (the first one) becomes impliable for all the masters.
 2023-06-02 15:50:32 +01:00
Cosimo Lupo
b6bb9dfef0
ttGlyphPen: only call dropImpliedOnCurvePoints for simple glyphs after fully formed 2023-06-02 13:53:00 +01:00
Cosimo Lupo
6a276d9f6a
dropImpliedOnCurvePoints: raise if incompatible, skip empty/composites 2023-06-02 13:51:28 +01:00
Behdad Esfahbod
54cfb5f696 [designspaceLib/avar2] Err if mappings axes ranges are being subset 2023-06-01 12:24:51 -06:00
Behdad Esfahbod
ddf16c9130 [designspaceLib/avar2] Apply review comments 2023-06-01 11:54:43 -06:00
Cosimo Lupo
3b62811b63
have dropImpliedOnCurvePoints return the set of point indices useful for testing 2023-06-01 18:21:59 +01:00
Cosimo Lupo
e19871981d
add docstring to dropImpliedOnCurvePoints function 2023-06-01 16:49:30 +01:00
Cosimo Lupo
b7f4e9b83e
move dropImpliedOnCurvePoints function to glyf table module 
so it can be used by client code on multiple glyf Glyph objects regardles of TTGlyphPen
 2023-06-01 16:49:29 +01:00
Cosimo Lupo
a73abc6b87
make drop_implied_oncurves work with multiple interpolatable glyphs 2023-06-01 16:49:29 +01:00
Cosimo Lupo
3bbc19abb1
TTGlyphPen: do not error with empty contours, simply ignore them 
Fixes https://github.com/googlefonts/fontmake/issues/1001
 2023-05-31 11:58:14 +01:00
Behdad Esfahbod
ca642e89c4 [designspaceLib/avar2] First stab at splitting mappings 2023-05-30 23:03:33 -06:00
Behdad Esfahbod
ce0a32d1a4 [varLib.builder] Fixup 2023-05-30 22:46:47 -06:00
Behdad Esfahbod
a8f9fa98ec [designspaceLib/docs] varLib spelling 2023-05-30 22:36:00 -06:00
Behdad Esfahbod
1b7c0bf19b [designspaceLib/avar2] Adjust version to 5.1 when writing mappings 2023-05-30 22:23:42 -06:00
Behdad Esfahbod
d513e563ff [designspaceLib/avar2] Add XML docs 2023-05-30 22:16:46 -06:00
Behdad Esfahbod
a99a75e8a6 [varLib/avar2] Use buildDeltaSetIndexMap() 
Also change buildDeltaSetIndexMap() to move the identity
optimization there. Update the only other callsite (COLRv2).
 2023-05-30 13:30:36 -06:00
Behdad Esfahbod
a08acf41f8 [varLib/avar2] Omit identity VarIdx map 2023-05-30 13:22:12 -06:00
Behdad Esfahbod
d915f08e76 [varLib/avar2] Don't require base master to be specified explicitly 
We can deduce it as empty mapping.
 2023-05-30 13:13:49 -06:00
Behdad Esfahbod
ff7f49a94c [varLib/avar2] Add compile test 2023-05-30 13:13:49 -06:00
Behdad Esfahbod
246d539e29 [designspaceLib/avar2] Warn if input location missing for an output axis 
https://github.com/fonttools/fonttools/pull/3123#issuecomment-1568852694
 2023-05-30 12:10:15 -06:00
Behdad Esfahbod
588cbc982d [designspaceLib/avar2] Rename variables 2023-05-30 11:55:48 -06:00
Khaled Hosny
a43f824af9 [feaLib] Support variable ligature caret position 
Allow variable scaler in ligature caret position and build
CaretValueFormat3 with DeviceTable. Does not support non-variable device
table, but can be added if someone really really wants it.
 2023-05-30 20:21:21 +03:00
Cosimo Lupo
0bf84f9c7b
Merge pull request #3129 from fonttools/privData_bytes 
privData needs to padded with bytes not str
 2023-05-30 12:10:30 +01:00
Behdad Esfahbod
3ba7e6d706 [instancer-solver] Fix a bug 
Fixes https://github.com/fonttools/fonttools/issues/3139
 2023-05-29 17:39:02 -06:00
Behdad Esfahbod
90e8595ef0 [designspaceLib/avar2] Document 2023-05-28 16:58:30 -06:00
Behdad Esfahbod
ae2305196a [designspaceLib/avar2] Store axis name, not tag, in <dimension> 2023-05-28 15:14:25 -06:00
Behdad Esfahbod
3a809dbbf3 [designspaceLib/avar2] Write out <mappings> element 2023-05-28 15:14:25 -06:00
Behdad Esfahbod
50b1fb3f01 [designspaceLib/avar2] Rename elements to <mappings><mapping> 2023-05-28 15:14:25 -06:00
Behdad Esfahbod
f27e843276 [designspaceLib/avar2] Flesh out AxisMapping API 2023-05-28 15:14:25 -06:00
Behdad Esfahbod
0b57567c14 [designspaceLib/avar2] Add AxisMappingDescriptor 2023-05-28 15:14:25 -06:00
Behdad Esfahbod
be9dacad74 [designspaceLib/avar2] Rename mapping to axisMappings 2023-05-28 15:14:25 -06:00
Behdad Esfahbod
5785fdeec3 [avar2] Emit the difference of input vs output 2023-05-28 15:14:25 -06:00
Behdad Esfahbod
b9e03b165b [avar2] Rewrite loop 2023-05-28 15:14:25 -06:00
Behdad Esfahbod
50fc8218b3 [designspace/varLib] Hack to read avar2 mapping and build avar2 table 
This just uses list of list of dictionaries. Should use proper objects.

https://github.com/fonttools/fonttools/issues/3049

https://github.com/harfbuzz/boring-expansion-spec/blob/main/avar2-in-designspace.md
 2023-05-28 15:14:25 -06:00
David Corbett
b8dcb85161 [otlLib] Fix error message in MarkBasePosBuilder 2023-05-28 20:29:49 +02:00
Khaled Hosny
fd854d70d8 [feaLib] Simplify variable scalars that don’t vary 
If a variable scalar does not vary (i.e. all values are the same), we
can simplify it and use a simple value instead. Arguably users shouldn’t
be using variable scalar in this case, but it helps when the feature
code is auto generated so each feaLib users doesn’t have to do the
check done here themselves.
 2023-05-27 02:56:11 +03:00
Khaled Hosny
f8abda4570 [feaLib] Refactor-out builder code handling variable scalars 
Refactor-out this piece of code to simplify the next commit.
 2023-05-27 02:55:07 +03:00