71 Commits

Author SHA1 Message Date
Cosimo Lupo
49bcbb916b
consistently do sys.exit(unittest.main()) in all test modules
So that when run as scrips they report test failures with exit code

Follow up on b7bb391033ef3255c90134da3d7aef50d2d5326d
2017-01-11 13:05:35 +00:00
Cosimo Lupo
e5dbc85463
[mtiLib] add __main__.py to allow running package as module
This now works:

$ fonttools mtiLib

or which is the same:

$ python -m fontTools.mtiLib
2017-01-11 12:15:33 +00:00
Cosimo Lupo
b7bb391033
don't use sys.exit(...) inside main(), but only under if __name__ == "__main__"
The convention is that sys.exit(...) is called only if a module is run as a script,
and that main() entry points use return statements to report exit codes: 0 (or None)
for successful execution, or any non-zero integer for errors.

E.g. see the console scripts generated when installing with pip.
2017-01-11 12:10:58 +00:00
Cosimo Lupo
ae05b2a583
[logging] for runnable modules, spell out module name instead of using __name__
If a module is run as script, as in `python module.py` or when using
`runpy.run_module()`, then __name__ == "__main__".

So when we instantiate modules' loggers with `logging.getLogger(__name__)`,
those loggers' name may become "__main__" when run as scripts, and hence
fall outside of the "fontTools" logging namespace.

fontTools.configureLogger() by default only configures the "fontTools"
library loggers, anything outside of it (e.g. logger called "__main__")
is not attached a handler.

So here I name loggers explicitly instead of relying on __name__, but
only for modules which can be run as "__main__".

Fixes #801
2017-01-11 11:58:17 +00:00
Behdad Esfahbod
6250b60ec3 [mtiLib] Test roundtripping XML->Python->XML as well
Most tests fail right now since when reading XML we don't set *Count
members for empty arrays; we don't set propagated counts either.
Fixes coming.
2017-01-02 23:23:44 -05:00
Behdad Esfahbod
3eacc23868 Update tests for previous commit
The following sed command can be used to update TTX sources for the LookupType
change:

$ sed -i'~' 's/<!-- LookupType=\(.\) -->/<LookupType value="\1"\/>/g' *.ttx
2016-12-28 20:29:43 -05:00
Behdad Esfahbod
8dada08d4d [mtiLib] Enable cmap test now that it passes
Was failing before 312203b6610f513509063dfc7e823bbf9ea55e29
2016-12-27 18:42:09 -05:00
Behdad Esfahbod
7236533eb2 [mtiLib] Prepare for enabling cmap test 2016-12-27 18:16:09 -05:00
Behdad Esfahbod
8528dc9d7c [mtiLib] Add commnent re emitting empty lookups 2016-12-27 15:22:23 -05:00
Behdad Esfahbod
4b38a20cee [mtiLib] Set lookup type even if lookup is empty
For real this time.
2016-12-27 15:19:22 -05:00
Behdad Esfahbod
6380b7041c [mtiLib] Set LookupType even for empty lookup 2016-12-27 15:17:04 -05:00
Behdad Esfahbod
7af5f9a343 [mtiLib] Port remaining types to new internal API 2016-12-27 15:15:48 -05:00
Behdad Esfahbod
86717f390b [mtiLib] Minor 2016-12-27 15:06:03 -05:00
Behdad Esfahbod
621a0613bc [mtiLib] Parse lookup-flags earlier
Such that we set them even if lookup block is empty.
2016-12-27 13:59:12 -05:00
Behdad Esfahbod
cf09589729 [mtiLib] Format 2016-12-27 13:42:17 -05:00
Behdad Esfahbod
a6178fd4fb [mtiLib] Fix and enable chained-glyph test 2016-12-27 13:40:27 -05:00
Behdad Esfahbod
1896353af0 [mtiLib] Enable testing same source against multiple tableTags 2016-12-27 13:38:51 -05:00
Behdad Esfahbod
2f800c9384 [mtiLib] Allow empty lookup 2016-12-27 13:37:11 -05:00
Behdad Esfahbod
edd46bb14a [mtiLib] Remove use of MockFont in tests
Tests pass on both Python 2 and 3 now. Yay!

MockFont is handy for mtiLib.__init__:main().  Not sure how useful it is
otherwise, and what to replace it with.
2016-12-27 13:28:06 -05:00
Behdad Esfahbod
f6294ba7bd [mtiLib] More deterministic output with MockFont 2016-12-27 13:09:39 -05:00
Behdad Esfahbod
8358a7248f [mtiLib] Make output more deterministic with MockFont
I'll first make Python 2 and 3 both generate same output for tests with
MockFont, then will probably hardcode glyphorder and remove MockFont
completely and remove hacks I added to make tests work with MockFont.
2016-12-27 13:03:37 -05:00
Behdad Esfahbod
2034cef52f Write test diffs to stderr, not stdout 2016-12-26 20:30:00 -05:00
Behdad Esfahbod
0661b0805b [mtiLib] Fix warnings in tests with Python3 2016-12-26 20:15:53 -05:00
Behdad Esfahbod
31b6aab8e1 [mtiLib] One more try to make bots happy 2016-12-26 18:06:44 -05:00
Behdad Esfahbod
ab01846a8d [mtiLib] Add some more tests 2016-12-26 17:35:21 -05:00
Behdad Esfahbod
2d3610bb6b Ignore class=0 when reading & writing ClassDef objects
class=0 items might be added as an optimization.  They have no semantic value.
Ignore them.

Fixes the last of mtiLib tests.
2016-12-26 17:26:14 -05:00
Behdad Esfahbod
101303ab50 [mtiLib] Fix two more tests 2016-12-26 17:14:39 -05:00
Behdad Esfahbod
fc25b26ca2 [mtiLib] Fix expected output of two remaining tests 2016-12-26 16:58:19 -05:00
Behdad Esfahbod
795e66747c Print XML output from compil-roundtripped object, not the built one
This is almost always the correct thing to print.  If the two differ, that's
bad, but print the better one.
2016-12-26 16:50:00 -05:00
Behdad Esfahbod
8c571d1b73 [mtiLib] Fix order of diffing test outputs 2016-12-26 16:49:48 -05:00
Behdad Esfahbod
3689f0ffdc [mtiLib] Whitespace 2016-12-26 16:39:50 -05:00
Behdad Esfahbod
aa3b94db0a [mtiLib] Fix mti/gpospairglyph test 2016-12-26 16:36:38 -05:00
Behdad Esfahbod
f4c9134957 [mtiLib] Fix gposmarktobase test 2016-12-26 16:29:20 -05:00
Behdad Esfahbod
4f6dea2d99 [mtiLib] Fix gpossingle test 2016-12-26 16:27:45 -05:00
Behdad Esfahbod
730f77a606 [mtiLib] Make test pass
mark-to-ligature was failing because we were not setting ClassCount.
2016-12-26 16:23:02 -05:00
Behdad Esfahbod
180362d30c [mtiLib] Add test data from spec, with test runner 2016-12-26 16:22:54 -05:00
Behdad Esfahbod
5858750dc3 [mtiLib] Fix warnings 2016-12-26 15:29:09 -05:00
Behdad Esfahbod
6c140cbba1 [testTools] Move MockFont from mtiLib to testTools
This is useful for testing beyond just mtiLib.
2016-12-26 14:34:29 -05:00
James Godfrey-Kittle
797061679a [mtiLib] Make tables in parsers, don't pass in 2016-06-30 14:16:58 -07:00
James Godfrey-Kittle
1b61637473 Add cmap handling to mtiLib 2016-06-30 12:50:39 -07:00
Behdad Esfahbod
93d08d4188 [mtiLib] Accept "u " as well as "U " in Unicode glyph references
Fixes https://github.com/googlei18n/fontmake/issues/86
2016-06-08 15:17:08 -07:00
Behdad Esfahbod
7a9c6be76c [mtiLib] Warn if trailing tabs are found 2016-04-27 17:04:25 -07:00
Behdad Esfahbod
71633457df [mtiLib] Ignore trailing tabs 2016-04-27 16:58:38 -07:00
Behdad Esfahbod
973270e7f9 [mtiLib] Assert that glyph name is not empty 2016-04-27 16:58:33 -07:00
Behdad Esfahbod
e9ecd07baa [mtiLib] Fix URL 2016-04-21 16:11:12 -07:00
Cosimo Lupo
54e6ab9478 mtiLib: add missing logging format string 2016-04-10 23:08:39 +01:00
Behdad Esfahbod
2a0359af4d Always import * from py23
Since py23 modifies some essential builtins, it's safe to import
everything all the time.  At least, that's how it was designed.
It's a bug if importing * breaks some code.
2016-04-06 18:15:43 -07:00
James Godfrey-Kittle
c4dd050d8d Replace one last call to debug() in mtiLib
I think this was mistakenly left out of
b62f5509524a49101ab6f211f1c3b63458f52f5e
2016-02-10 14:18:38 -08:00
Cosimo Lupo
b62f550952 [mtiLib] replace print with logger
inside main(), I just do a basic config for the library logger, but keep
the debug messages from mtiLib turned off.
2016-01-27 19:02:48 +00:00
Cosimo Lupo
f99a09fdbe [mtiLib] import unicode_literals; use py23.open with utf-8 encoding 2016-01-26 15:45:32 +00:00