From 04ffe0036dd568d1d9a441e590535edd58ce9157 Mon Sep 17 00:00:00 2001 From: Shadowfacts Date: Fri, 14 Aug 2020 21:56:38 -0400 Subject: [PATCH] Fix feed update failing on missing favicon --- lib/frenzy/task/fetch_favicon.ex | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/frenzy/task/fetch_favicon.ex b/lib/frenzy/task/fetch_favicon.ex index 5c2b46c..1e4103d 100644 --- a/lib/frenzy/task/fetch_favicon.ex +++ b/lib/frenzy/task/fetch_favicon.ex @@ -25,7 +25,8 @@ defmodule Frenzy.Task.FetchFavicon do favicon_url = fetch_favicon_url_from_webpage(site_url) || URI.merge(site_url, "/favicon.ico") - with %Feed{favicon_url: old_url} when old_url != favicon_url <- feed, + with true <- is_binary(favicon_url), + %Feed{favicon_url: old_url} when old_url != favicon_url <- feed, {:ok, favicon_data} <- fetch_favicon_data(favicon_url) do changeset = Feed.changeset(feed, %{