From ddceb28803020595fa5ebf79e02e5fddd6d21450 Mon Sep 17 00:00:00 2001 From: Shadowfacts Date: Wed, 8 Sep 2021 20:10:19 -0400 Subject: [PATCH] Fix update feeds thinking all items already exist Repo.exists? needs a query, not the keyword list --- lib/frenzy/item.ex | 3 ++- lib/frenzy/update_feeds.ex | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/frenzy/item.ex b/lib/frenzy/item.ex index 2b8bf08..4a9f381 100644 --- a/lib/frenzy/item.ex +++ b/lib/frenzy/item.ex @@ -1,6 +1,7 @@ defmodule Frenzy.Item do use Ecto.Schema import Ecto.Changeset + import Ecto.Query alias FrenzyWeb.Router.Helpers, as: Routes alias FrenzyWeb.Endpoint @@ -87,6 +88,6 @@ defmodule Frenzy.Item do end def exists?(feed_id, guid) do - Frenzy.Repo.exists?(__MODULE__, feed_id: feed_id, guid: guid) + Frenzy.Repo.exists?(from i in __MODULE__, where: i.feed_id == ^feed_id and i.guid == ^guid) end end diff --git a/lib/frenzy/update_feeds.ex b/lib/frenzy/update_feeds.ex index c1f0dac..be95a45 100644 --- a/lib/frenzy/update_feeds.ex +++ b/lib/frenzy/update_feeds.ex @@ -159,7 +159,6 @@ defmodule Frenzy.UpdateFeeds do end Enum.each(rss.items, fn entry -> - # todo: use Repo.exists for this unless Item.exists?(feed.id, entry.guid) do CreateItem.start_link(feed, entry) end