From 09ee456b96138acc909e4a0e24c0fc405c6d661f Mon Sep 17 00:00:00 2001 From: ConnorSkees <39542938+ConnorSkees@users.noreply.github.com> Date: Fri, 17 Apr 2020 13:12:06 -0400 Subject: [PATCH] explicitly match on all units in Unit::kind --- src/unit/mod.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/unit/mod.rs b/src/unit/mod.rs index 17963a5..277490d 100644 --- a/src/unit/mod.rs +++ b/src/unit/mod.rs @@ -128,7 +128,8 @@ impl Unit { } } - pub fn kind(&self) -> UnitKind { + /// Used internally to determine if two units are comparable or not + fn kind(&self) -> UnitKind { match self { Unit::Px | Unit::Mm | Unit::In | Unit::Cm | Unit::Q | Unit::Pt | Unit::Pc => { UnitKind::Absolute @@ -149,7 +150,7 @@ impl Unit { Unit::Hz | Unit::Khz => UnitKind::Frequency, Unit::Dpi | Unit::Dpcm | Unit::Dppx | Unit::X => UnitKind::Resolution, Unit::None => UnitKind::None, - _ => UnitKind::Other, + Unit::Fr | Unit::Percent | Unit::Unknown(..) | Unit::Mul(..) => UnitKind::Other, } } }