From 3c1c55038f2a77165838cccadbfde05ff40343ef Mon Sep 17 00:00:00 2001 From: ConnorSkees <39542938+ConnorSkees@users.noreply.github.com> Date: Sun, 24 May 2020 12:19:08 -0400 Subject: [PATCH] better handle multiline errors this is more of a quick fix for potential panics; it does not properly substitute for real multiline error messages --- src/error.rs | 2 +- tests/if.rs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/error.rs b/src/error.rs index 840c753..bc6db85 100644 --- a/src/error.rs +++ b/src/error.rs @@ -66,7 +66,7 @@ impl Display for SassError { "{}| {}{}", padding, vec![' '; loc.begin.column].iter().collect::(), - vec!['^'; loc.end.column - loc.begin.column] + vec!['^'; loc.end.column.max(loc.begin.column) - loc.begin.column.min(loc.end.column)] .iter() .collect::() )?; diff --git a/tests/if.rs b/tests/if.rs index 13f8add..34bb47c 100644 --- a/tests/if.rs +++ b/tests/if.rs @@ -130,3 +130,4 @@ error!(unclosed_dbl_quote, "@if true \" {}", "Error: Expected \"."); error!(unclosed_sgl_quote, "@if true ' {}", "Error: Expected '."); error!(unclosed_call_args, "@if a({}", "Error: expected \")\"."); error!(nothing_after_div, "@if a/", "Error: Expected expression."); +error!(multiline_error, "@if \"\n\"{}", "Error: Expected \".");