shadowfacts/grass
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

prefer #[ignore] over commenting out tests

Browse Source
This commit is contained in:
ConnorSkees 2020-04-25 12:16:10 -04:00
parent eb690b9adf
commit 637dc39544
5 changed files with 42 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/color.rs
View File

@ -278,10 +278,11 @@ test!(
"a {\n color: black;\n}\n" "a {\n color: black;\n}\n"
); );
test!(invert_number, "a {\n color: invert(10%);\n}\n"); test!(invert_number, "a {\n color: invert(10%);\n}\n");
// test!( test!(
// invert_number_casing, #[ignore]
// "a {\n color: iNveRt(10%);\n}\n" invert_number_casing,
// ); "a {\n color: iNveRt(10%);\n}\n"
);
test!( test!(
invert_weight_percent, invert_weight_percent,
"a {\n color: invert(white, 20%);\n}\n", "a {\n color: invert(white, 20%);\n}\n",

5
tests/division.rs
View File

@ -28,8 +28,3 @@ test!(
"a {\n slash-after-comma: (1, / 2);\n}\n", "a {\n slash-after-comma: (1, / 2);\n}\n",
"a {\n slash-after-comma: 1, /2;\n}\n" "a {\n slash-after-comma: 1, /2;\n}\n"
); );
// error!(
// none_div_unit,
// "a {\n color: (35 / 7%);\n}\n",
// "Error: 5%^-1 isn't a valid CSS value."
// );

36
tests/meta.rs
View File

@ -43,27 +43,30 @@ test!(
"a {\n color: feature-exists(at-error)\n}\n", "a {\n color: feature-exists(at-error)\n}\n",
"a {\n color: true;\n}\n" "a {\n color: true;\n}\n"
); );
// Uncomment as more features are added
test!( test!(
feature_exists_global_variable_shadowing, feature_exists_global_variable_shadowing,
"a {\n color: feature-exists(global-variable-shadowing)\n}\n", "a {\n color: feature-exists(global-variable-shadowing)\n}\n",
"a {\n color: true;\n}\n" "a {\n color: true;\n}\n"
); );
// test!( // Unignore as more features are added
// feature_exists_extend_selector_pseudoclass, test!(
// "a {\n color: feature-exists(extend-selector-pseudoclass)\n}\n", #[ignore]
// "a {\n color: true;\n}\n" feature_exists_extend_selector_pseudoclass,
// ); "a {\n color: feature-exists(extend-selector-pseudoclass)\n}\n",
"a {\n color: true;\n}\n"
);
test!( test!(
feature_exists_units_level_3, feature_exists_units_level_3,
"a {\n color: feature-exists(units-level-3)\n}\n", "a {\n color: feature-exists(units-level-3)\n}\n",
"a {\n color: true;\n}\n" "a {\n color: true;\n}\n"
); );
// test!( // Unignore as more features are added
// feature_exists_custom_property, test!(
// "a {\n color: feature-exists(custom-property)\n}\n", #[ignore]
// "a {\n color: true;\n}\n" feature_exists_custom_property,
// ); "a {\n color: feature-exists(custom-property)\n}\n",
"a {\n color: true;\n}\n"
);
test!( test!(
feature_exists_nonsense, feature_exists_nonsense,
"a {\n color: feature-exists(foo)\n}\n", "a {\n color: feature-exists(foo)\n}\n",
@ -346,8 +349,9 @@ test!(
"a {\n color: inspect(1 2 3)\n}\n", "a {\n color: inspect(1 2 3)\n}\n",
"a {\n color: 1 2 3;\n}\n" "a {\n color: 1 2 3;\n}\n"
); );
// test!( test!(
// inspect_comma_list, #[ignore]
// "a {\n color: inspect(1, 2, 3)\n}\n", inspect_comma_list,
// "a {\n color: 1, 2, 3;\n}\n" "a {\n color: inspect(1, 2, 3)\n}\n",
// ); "a {\n color: 1, 2, 3;\n}\n"
);

22
tests/selectors.rs
View File

@ -64,16 +64,18 @@ test!(
selector_attribute_equals, selector_attribute_equals,
"[attr=val] {\n color: red;\n}\n" "[attr=val] {\n color: red;\n}\n"
); );
// test!( test!(
// selector_attribute_removes_single_quotes, #[ignore]
// "[attr='val'] {\n color: red;\n}\n", selector_attribute_removes_single_quotes,
// "[attr=val] {\n color: red;\n}\n" "[attr='val'] {\n color: red;\n}\n",
// ); "[attr=val] {\n color: red;\n}\n"
// test!( );
// selector_attribute_removes_double_quotes, test!(
// "[attr=\"val\"] {\n color: red;\n}\n", #[ignore]
// "[attr=val] {\n color: red;\n}\n" selector_attribute_removes_double_quotes,
// ); "[attr=\"val\"] {\n color: red;\n}\n",
"[attr=val] {\n color: red;\n}\n"
);
test!( test!(
selector_attribute_maintains_quotes_around_invalid_identifier, selector_attribute_maintains_quotes_around_invalid_identifier,
"[attr=\"val.\"] {\n color: red;\n}\n" "[attr=\"val.\"] {\n color: red;\n}\n"

5
tests/units.rs
View File

@ -83,6 +83,11 @@ error!(
"a {\n color: 1rem * 1px * 1rad * 1foo;\n}\n", "a {\n color: 1rem * 1px * 1rad * 1foo;\n}\n",
"Error: 1rem*px*rad*foo isn't a valid CSS value." "Error: 1rem*px*rad*foo isn't a valid CSS value."
); );
error!(
#[ignore]
none_div_unit,
"a {\n color: (35 / 7%);\n}\n", "Error: 5%^-1 isn't a valid CSS value."
);
macro_rules! test_unit_addition { macro_rules! test_unit_addition {
($u1:ident, $u2:ident, $out:literal) => { ($u1:ident, $u2:ident, $out:literal) => {