From 69e0938b012f0da9ebbbe4bea2e80960ad3e60aa Mon Sep 17 00:00:00 2001
From: Connor Skees <connor1skees@gmail.com>
Date: Sun, 9 Jul 2023 23:32:13 +0000
Subject: [PATCH] ignore more false positive clippy lints

---
 crates/compiler/src/ast/args.rs         |  2 +-
 crates/compiler/src/lib.rs              |  5 ++++
 crates/compiler/src/parse/stylesheet.rs |  7 +++--
 crates/lib/src/lib.rs                   | 35 +++++++------------------
 4 files changed, 19 insertions(+), 30 deletions(-)

diff --git a/crates/compiler/src/ast/args.rs b/crates/compiler/src/ast/args.rs
index 9e929b7..378d7fc 100644
--- a/crates/compiler/src/ast/args.rs
+++ b/crates/compiler/src/ast/args.rs
@@ -250,7 +250,7 @@ impl ArgumentResult {
         let len = self.len();
         if len > max {
             let mut err = String::with_capacity(50);
-            #[allow(clippy::format_push_string)]
+            #[allow(unknown_lints, clippy::format_push_string)]
             err.push_str(&format!("Only {max} argument", max = max));
             if max != 1 {
                 err.push('s');
diff --git a/crates/compiler/src/lib.rs b/crates/compiler/src/lib.rs
index dfd6e09..796af24 100644
--- a/crates/compiler/src/lib.rs
+++ b/crates/compiler/src/lib.rs
@@ -58,6 +58,11 @@ grass input.scss
     clippy::cast_precision_loss,
     clippy::float_cmp,
 
+    // todo: unignore once we bump MSRV
+    clippy::format_push_string,
+    clippy::unnecessary_unwrap,
+    clippy::needless_late_init,
+
     unknown_lints,
 )]
 
diff --git a/crates/compiler/src/parse/stylesheet.rs b/crates/compiler/src/parse/stylesheet.rs
index 39cd7a4..e582bd5 100644
--- a/crates/compiler/src/parse/stylesheet.rs
+++ b/crates/compiler/src/parse/stylesheet.rs
@@ -1196,10 +1196,9 @@ pub(crate) trait StylesheetParser<'a>: BaseParser<'a> + Sized {
 
             let right = self.supports_condition_in_parens()?;
             operation = Some(AstSupportsCondition::Operation {
-                left: Box::new(
-                    operation
-                        .unwrap_or(AstSupportsCondition::Interpolation(expression.clone().node)),
-                ),
+                left: Box::new(operation.unwrap_or_else(|| {
+                    AstSupportsCondition::Interpolation(expression.clone().node)
+                })),
                 operator: operator.clone(),
                 right: Box::new(right),
             });
diff --git a/crates/lib/src/lib.rs b/crates/lib/src/lib.rs
index 39f403e..18acce6 100644
--- a/crates/lib/src/lib.rs
+++ b/crates/lib/src/lib.rs
@@ -36,46 +36,31 @@ grass input.scss
 #![deny(missing_debug_implementations)]
 #![allow(
     clippy::use_self,
-    clippy::missing_docs_in_private_items,
-    clippy::unreachable,
-    clippy::module_name_repetitions,
     // filter isn't fallible
     clippy::manual_filter_map,
-    clippy::new_ret_no_self,
     renamed_and_removed_lints,
     clippy::unknown_clippy_lints,
     clippy::single_match,
-    clippy::unimplemented,
-    clippy::option_if_let_else,
-    clippy::branches_sharing_code,
-    clippy::derive_partial_eq_without_eq,
-
-    // temporarily allowed while under heavy development.
-    // eventually these allows should be refactored away
-    // to no longer be necessary
-    clippy::too_many_lines,
-    clippy::cast_possible_truncation,
+    clippy::new_without_default,
     clippy::single_match_else,
-    clippy::redundant_pub_crate,
-    // the api is changing too often to allot this
-    clippy::missing_errors_doc,
-    clippy::missing_const_for_fn,
     clippy::multiple_crate_versions,
-
     clippy::wrong_self_convention,
-    clippy::items_after_statements,
-    // this is only available on nightly
+    clippy::comparison_chain,
+
+    // these features are only available on nightly
     clippy::unnested_or_patterns,
     clippy::uninlined_format_args,
 
-    // todo:
+    // todo: these should be enabled
     clippy::cast_sign_loss,
     clippy::cast_lossless,
     clippy::cast_precision_loss,
     clippy::float_cmp,
-    clippy::wildcard_imports,
-    clippy::comparison_chain,
-    clippy::bool_to_int_with_if,
+
+    // todo: unignore once we bump MSRV
+    clippy::format_push_string,
+    clippy::unnecessary_unwrap,
+    clippy::needless_late_init,
 
     unknown_lints,
 )]