From 789c55ac3d125ccfa1f1fd1a193e54e5800d97fb Mon Sep 17 00:00:00 2001 From: ConnorSkees <39542938+ConnorSkees@users.noreply.github.com> Date: Sat, 8 Feb 2020 16:01:21 -0500 Subject: [PATCH] Refactor Value::is_true() --- src/value.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/value.rs b/src/value.rs index 3ab54f6..f65a645 100644 --- a/src/value.rs +++ b/src/value.rs @@ -226,8 +226,11 @@ impl Value { } pub fn is_true(&self) -> bool { - let s = self.eval(); - !(s == Value::Null || s == Value::False) + match self { + Value::Null | Value::False => false, + Self::BinaryOp(..) => self.eval().is_true(), + _ => true + } } pub fn unquote(self) -> Self {