From 96d29f45b8ed0bbeeb3fecc66827378a7737e474 Mon Sep 17 00:00:00 2001
From: ConnorSkees <39542938+ConnorSkees@users.noreply.github.com>
Date: Sun, 16 Feb 2020 16:03:22 -0500
Subject: [PATCH] Bounds check for fade_(in|out)

---
 src/builtin/color/opacity.rs | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/builtin/color/opacity.rs b/src/builtin/color/opacity.rs
index 4d5d2cf..3f7aff3 100644
--- a/src/builtin/color/opacity.rs
+++ b/src/builtin/color/opacity.rs
@@ -2,6 +2,7 @@ use std::collections::BTreeMap;
 
 use super::Builtin;
 use crate::common::QuoteKind;
+use crate::value::Number;
 use crate::units::Unit;
 use crate::value::Value;
 
@@ -28,7 +29,7 @@ pub(crate) fn register(f: &mut BTreeMap<String, Builtin>) {
             v => return Err(format!("$color: {} is not a color.", v).into()),
         };
         let amount = match arg!(args, 1, "amount").eval() {
-            Value::Dimension(n, _) => n,
+            Value::Dimension(n, u) => bound!("amount", n, u, 0, 1),
             v => return Err(format!("$amount: {} is not a number.", v).into()),
         };
         Ok(Value::Color(color.fade_in(amount)))
@@ -40,7 +41,7 @@ pub(crate) fn register(f: &mut BTreeMap<String, Builtin>) {
             v => return Err(format!("$color: {} is not a color.", v).into()),
         };
         let amount = match arg!(args, 1, "amount").eval() {
-            Value::Dimension(n, _) => n,
+            Value::Dimension(n, u) => bound!("amount", n, u, 0, 1),
             v => return Err(format!("$amount: {} is not a number.", v).into()),
         };
         Ok(Value::Color(color.fade_in(amount)))
@@ -52,7 +53,7 @@ pub(crate) fn register(f: &mut BTreeMap<String, Builtin>) {
             v => return Err(format!("$color: {} is not a color.", v).into()),
         };
         let amount = match arg!(args, 1, "amount").eval() {
-            Value::Dimension(n, _) => n,
+            Value::Dimension(n, u) => bound!("amount", n, u, 0, 1),
             v => return Err(format!("$amount: {} is not a number.", v).into()),
         };
         Ok(Value::Color(color.fade_out(amount)))
@@ -64,7 +65,7 @@ pub(crate) fn register(f: &mut BTreeMap<String, Builtin>) {
             v => return Err(format!("$color: {} is not a color.", v).into()),
         };
         let amount = match arg!(args, 1, "amount").eval() {
-            Value::Dimension(n, _) => n,
+            Value::Dimension(n, u) => bound!("amount", n, u, 0, 1),
             v => return Err(format!("$amount: {} is not a number.", v).into()),
         };
         Ok(Value::Color(color.fade_out(amount)))