From d300d4e1fc69a65b03ee2ca17b813456b115d93c Mon Sep 17 00:00:00 2001 From: ConnorSkees <39542938+ConnorSkees@users.noreply.github.com> Date: Thu, 21 May 2020 00:09:52 -0400 Subject: [PATCH] test for ] in value --- src/utils/comment_whitespace.rs | 3 ++- src/value/parse.rs | 2 +- tests/error.rs | 6 +++++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/utils/comment_whitespace.rs b/src/utils/comment_whitespace.rs index 78579af..1b8aeda 100644 --- a/src/utils/comment_whitespace.rs +++ b/src/utils/comment_whitespace.rs @@ -95,7 +95,8 @@ pub(crate) fn eat_comment>( let mut span = if let Some(tok) = toks.peek() { tok.pos() } else { - todo!() + // Hit this path: "/*" + todo!("") }; while let Some(tok) = toks.next() { span = span.merge(tok.pos()); diff --git a/src/value/parse.rs b/src/value/parse.rs index df5da4b..5d2a8f8 100644 --- a/src/value/parse.rs +++ b/src/value/parse.rs @@ -900,7 +900,7 @@ impl Value { } } ';' | '}' | '{' => return None, - ':' | '?' | ')' | '@' | '^' => return Some(Err(("expected \";\".", span).into())), + ':' | '?' | ')' | '@' | '^' | ']' => return Some(Err(("expected \";\".", span).into())), v if v as u32 >= 0x80 || v.is_control() => { return Some(Err(("Expected expression.", span).into())) } diff --git a/tests/error.rs b/tests/error.rs index 2f0c32c..8e5eb1b 100644 --- a/tests/error.rs +++ b/tests/error.rs @@ -68,5 +68,9 @@ error!( ); error!( toplevel_forward_slash, - "/a {color, red;}", "Error: expected selector." + "/a {color: red;}", "Error: expected selector." +); +error!( + close_bracket_in_value, + "a {color: red]}", "Error: expected \";\"." );