shadowfacts/grass
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

explicitly enumerate missing at rule kinds

Browse Source
This commit is contained in:
ConnorSkees 2020-04-26 01:37:51 -04:00
parent 4a2503b04c
commit d49eb7e18b
2 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/atrule/kind.rs
View File

@ -12,6 +12,10 @@ pub enum AtRuleKind {
Forward, Forward,
/// Extends the CSS at-rule to load styles, mixins, functions, /// Extends the CSS at-rule to load styles, mixins, functions,
/// and variables from other stylesheets /// and variables from other stylesheets
///
/// The definition inside `grass` however differs in that
/// the @import rule refers to a plain css import
/// e.g. `@import url(foo);`
Import, Import,
Mixin, Mixin,
Content, Content,
@ -31,7 +35,10 @@ pub enum AtRuleKind {
/// Prints a message for debugging purposes /// Prints a message for debugging purposes
Debug, Debug,
If, If,
Else, // @else is considered a part of @each, and so is not parsed individually
// TODO: give proper error message for encountering @else? right now
// it is parsed as an unknown at rule
// Else,
Each, Each,
For, For,
While, While,
@ -66,7 +73,6 @@ impl From<&str> for AtRuleKind {
"warn" => Self::Warn, "warn" => Self::Warn,
"debug" => Self::Debug, "debug" => Self::Debug,
"if" => Self::If, "if" => Self::If,
"else" => Self::Else,
"each" => Self::Each, "each" => Self::Each,
"for" => Self::For, "for" => Self::For,
"while" => Self::While, "while" => Self::While,
@ -95,7 +101,6 @@ impl Display for AtRuleKind {
Self::Warn => write!(f, "@warn"), Self::Warn => write!(f, "@warn"),
Self::Debug => write!(f, "@debug"), Self::Debug => write!(f, "@debug"),
Self::If => write!(f, "@if"), Self::If => write!(f, "@if"),
Self::Else => write!(f, "@else"),
Self::Each => write!(f, "@each"), Self::Each => write!(f, "@each"),
Self::For => write!(f, "@for"), Self::For => write!(f, "@for"),
Self::While => write!(f, "@while"), Self::While => write!(f, "@while"),

11
src/atrule/mod.rs
View File

@ -144,7 +144,6 @@ impl AtRule {
span: kind_span, span: kind_span,
} }
} }
AtRuleKind::Use => todo!("@use not yet implemented"),
AtRuleKind::AtRoot => { AtRuleKind::AtRoot => {
let mut selector = &Selector::replace( let mut selector = &Selector::replace(
super_selector, super_selector,
@ -210,18 +209,15 @@ impl AtRule {
node: parse_each(toks, scope, super_selector, kind_span)?, node: parse_each(toks, scope, super_selector, kind_span)?,
span: kind_span, span: kind_span,
}, },
AtRuleKind::Extend => todo!("@extend not yet implemented"),
AtRuleKind::If => Spanned { AtRuleKind::If => Spanned {
node: AtRule::If(If::from_tokens(toks)?), node: AtRule::If(If::from_tokens(toks)?),
span: kind_span, span: kind_span,
}, },
AtRuleKind::Else => todo!("@else not yet implemented"),
AtRuleKind::For => Spanned { AtRuleKind::For => Spanned {
node: for_rule::parse_for(toks, scope, super_selector, kind_span)?, node: for_rule::parse_for(toks, scope, super_selector, kind_span)?,
span: kind_span, span: kind_span,
}, },
AtRuleKind::While => parse_while(toks, kind_span)?, AtRuleKind::While => parse_while(toks, kind_span)?,
AtRuleKind::Keyframes => todo!("@keyframes not yet implemented"),
AtRuleKind::Unknown(name) => Spanned { AtRuleKind::Unknown(name) => Spanned {
node: AtRule::Unknown(UnknownAtRule::from_tokens( node: AtRule::Unknown(UnknownAtRule::from_tokens(
toks, toks,
@ -240,7 +236,12 @@ impl AtRule {
node: AtRule::Include(eat_include(toks, scope, super_selector)?), node: AtRule::Include(eat_include(toks, scope, super_selector)?),
span: kind_span, span: kind_span,
}, },
_ => todo!("encountered unimplemented at rule"), AtRuleKind::Import => todo!("@import not yet implemented"),
AtRuleKind::Forward => todo!("@forward not yet implemented"),
AtRuleKind::Supports => todo!("@supports not yet implemented"),
AtRuleKind::Keyframes => todo!("@keyframes not yet implemented"),
AtRuleKind::Extend => todo!("@extend not yet implemented"),
AtRuleKind::Use => todo!("@use not yet implemented"),
}) })
} }
} }