From 385ee4843a21c875ce33c769f15c195325d4358c Mon Sep 17 00:00:00 2001 From: Bryan Naegele Date: Sun, 4 Feb 2024 21:44:37 -0700 Subject: [PATCH] Phoenix 1.2.0 release prep (#248) --- instrumentation/opentelemetry_phoenix/CHANGELOG.md | 14 ++++++++++++++ instrumentation/opentelemetry_phoenix/README.md | 7 ++++++- instrumentation/opentelemetry_phoenix/mix.exs | 2 +- 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/instrumentation/opentelemetry_phoenix/CHANGELOG.md b/instrumentation/opentelemetry_phoenix/CHANGELOG.md index d309648..9d14159 100644 --- a/instrumentation/opentelemetry_phoenix/CHANGELOG.md +++ b/instrumentation/opentelemetry_phoenix/CHANGELOG.md @@ -1,5 +1,19 @@ # Changelog +## 1.2.0 + +### Features + +* Add support for LiveView courtesy of @derekkraan + +### Fixes + +* Do not set a span as errored for exceptions, only based on 5xx HTTP status + +### Changed + +* Minimum supported Elixir version changed to 1.11. + ## 1.1.1 ### Fixes diff --git a/instrumentation/opentelemetry_phoenix/README.md b/instrumentation/opentelemetry_phoenix/README.md index 73f227e..d7e3764 100644 --- a/instrumentation/opentelemetry_phoenix/README.md +++ b/instrumentation/opentelemetry_phoenix/README.md @@ -22,11 +22,16 @@ may be supplied. ```elixir def deps do [ - {:opentelemetry_phoenix, "~> 1.1"} + {:opentelemetry_phoenix, "~> 1.2"} ] end ``` +It is high recommended to also install [OpentelemetryCowboy](https://hex.pm/packages/opentelemetry_cowboy) to capture the full +request lifecycle. Phoenix only handles part of the request lifecycle which can lead +to incomplete request durations and lost traces for requests terminated at the socket +level or before reaching Phoenix. + ## Compatibility Matrix | OpentelemetryPhoenix Version | Otel Version | Notes | diff --git a/instrumentation/opentelemetry_phoenix/mix.exs b/instrumentation/opentelemetry_phoenix/mix.exs index 2de8532..2813aef 100644 --- a/instrumentation/opentelemetry_phoenix/mix.exs +++ b/instrumentation/opentelemetry_phoenix/mix.exs @@ -1,7 +1,7 @@ defmodule OpentelemetryPhoenix.MixProject do use Mix.Project - @version "1.1.1" + @version "1.2.0" def project do [