From 8292870b662d4056b3dcdf16eb2563891b4b1943 Mon Sep 17 00:00:00 2001 From: Cedric Ziel Date: Tue, 23 May 2023 12:49:29 +0200 Subject: [PATCH] Add db.name to ecto spans (#172) * Add db.name to ecto spans As per the spec, the db.name attribute is required on database spans. This changes adds it. Ref: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#call-level-attributes * Add db.name attribute to tests * Changelog update * Update instrumentation/opentelemetry_ecto/test/opentelemetry_ecto_test.exs * Update instrumentation/opentelemetry_ecto/test/opentelemetry_ecto_test.exs --- instrumentation/opentelemetry_ecto/CHANGELOG.md | 6 ++++++ .../opentelemetry_ecto/lib/opentelemetry_ecto.ex | 1 + .../opentelemetry_ecto/test/opentelemetry_ecto_test.exs | 2 ++ 3 files changed, 9 insertions(+) diff --git a/instrumentation/opentelemetry_ecto/CHANGELOG.md b/instrumentation/opentelemetry_ecto/CHANGELOG.md index 81b7189..60dc1e7 100644 --- a/instrumentation/opentelemetry_ecto/CHANGELOG.md +++ b/instrumentation/opentelemetry_ecto/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## 1.1.1 + +### Changed + +* Add db.name to ecto spans + ## 1.1.0 ### Changed diff --git a/instrumentation/opentelemetry_ecto/lib/opentelemetry_ecto.ex b/instrumentation/opentelemetry_ecto/lib/opentelemetry_ecto.ex index 25d0845..0635a4f 100644 --- a/instrumentation/opentelemetry_ecto/lib/opentelemetry_ecto.ex +++ b/instrumentation/opentelemetry_ecto/lib/opentelemetry_ecto.ex @@ -92,6 +92,7 @@ defmodule OpentelemetryEcto do "db.statement": query, source: source, "db.instance": database, + "db.name": database, "db.url": url, "total_time_#{time_unit}s": System.convert_time_unit(total_time, :native, time_unit) } diff --git a/instrumentation/opentelemetry_ecto/test/opentelemetry_ecto_test.exs b/instrumentation/opentelemetry_ecto/test/opentelemetry_ecto_test.exs index 2c02025..082b522 100644 --- a/instrumentation/opentelemetry_ecto/test/opentelemetry_ecto_test.exs +++ b/instrumentation/opentelemetry_ecto/test/opentelemetry_ecto_test.exs @@ -50,6 +50,7 @@ defmodule OpentelemetryEctoTest do assert %{ "db.instance": "opentelemetry_ecto_test", + "db.name": "opentelemetry_ecto_test", "db.statement": "SELECT u0.\"id\", u0.\"email\" FROM \"users\" AS u0", "db.type": :sql, "db.url": "ecto://localhost", @@ -82,6 +83,7 @@ defmodule OpentelemetryEctoTest do assert %{ "db.instance": "opentelemetry_ecto_test", + "db.name": "opentelemetry_ecto_test", "db.statement": "SELECT p0.\"id\", p0.\"body\", p0.\"user_id\" FROM \"posts\" AS p0", "db.type": :sql, "db.url": "ecto://localhost",