Remove unnecessary default for Oban (#264)
These fields are required in `Oban.Job`
This commit is contained in:
parent
0dbda341f2
commit
de84e7b275
|
@ -62,7 +62,7 @@ We'd love your help!. Use tags [up-for-grabs][up-for-grabs-issues] and
|
||||||
|
|
||||||
- For more information on OpenTelemetry, see [opentelemetry.io](https://opentelemetry.io).
|
- For more information on OpenTelemetry, see [opentelemetry.io](https://opentelemetry.io).
|
||||||
- For conventions used in OpenTelemetry traces, see the following [readme](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/README.md).
|
- For conventions used in OpenTelemetry traces, see the following [readme](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/README.md).
|
||||||
- For help or feedback on this project, join us in [GitHub Discussions](https://github.com/open-telemetry/opentelemetry-erlang-contrib/discussions), `#otel-erlang-elixir` channel in the [CNCF slack](https://slack.cncf.io/), and `#opentelemetry` channel in the [Elixir Lang slack](https://elixir-slackin.herokuapp.com/)
|
- For help or feedback on this project, join us in [GitHub Discussions](https://github.com/open-telemetry/opentelemetry-erlang-contrib/discussions), `#otel-erlang-elixir` channel in the [CNCF slack](https://slack.cncf.io/), and `#opentelemetry` channel in the [Elixir Lang slack](https://elixir-slack.community/)
|
||||||
- Erlang SIG [community page](https://github.com/open-telemetry/community#special-interest-groups)
|
- Erlang SIG [community page](https://github.com/open-telemetry/community#special-interest-groups)
|
||||||
|
|
||||||
## License
|
## License
|
||||||
|
|
|
@ -31,7 +31,7 @@
|
||||||
<a href="https://twitter.com/elixirphoenix">Twitter @elixirphoenix</a>
|
<a href="https://twitter.com/elixirphoenix">Twitter @elixirphoenix</a>
|
||||||
</li>
|
</li>
|
||||||
<li>
|
<li>
|
||||||
<a href="https://elixir-slackin.herokuapp.com/">Elixir on Slack</a>
|
<a href="https://elixir-slack.community/">Elixir on Slack</a>
|
||||||
</li>
|
</li>
|
||||||
<li>
|
<li>
|
||||||
<a href="https://discord.gg/elixir">Elixir on Discord</a>
|
<a href="https://discord.gg/elixir">Elixir on Discord</a>
|
||||||
|
|
|
@ -53,7 +53,7 @@ defmodule OpentelemetryOban do
|
||||||
|
|
||||||
def insert(name \\ Oban, %Changeset{} = changeset) do
|
def insert(name \\ Oban, %Changeset{} = changeset) do
|
||||||
attributes = attributes_before_insert(changeset)
|
attributes = attributes_before_insert(changeset)
|
||||||
worker = Changeset.get_field(changeset, :worker, "unknown")
|
worker = Changeset.get_field(changeset, :worker)
|
||||||
|
|
||||||
OpenTelemetry.Tracer.with_span "#{worker} send", attributes: attributes, kind: :producer do
|
OpenTelemetry.Tracer.with_span "#{worker} send", attributes: attributes, kind: :producer do
|
||||||
changeset = add_tracing_information_to_meta(changeset)
|
changeset = add_tracing_information_to_meta(changeset)
|
||||||
|
@ -75,7 +75,7 @@ defmodule OpentelemetryOban do
|
||||||
|
|
||||||
def insert!(name \\ Oban, %Changeset{} = changeset) do
|
def insert!(name \\ Oban, %Changeset{} = changeset) do
|
||||||
attributes = attributes_before_insert(changeset)
|
attributes = attributes_before_insert(changeset)
|
||||||
worker = Changeset.get_field(changeset, :worker, "unknown")
|
worker = Changeset.get_field(changeset, :worker)
|
||||||
|
|
||||||
OpenTelemetry.Tracer.with_span "#{worker} send", attributes: attributes, kind: :producer do
|
OpenTelemetry.Tracer.with_span "#{worker} send", attributes: attributes, kind: :producer do
|
||||||
changeset = add_tracing_information_to_meta(changeset)
|
changeset = add_tracing_information_to_meta(changeset)
|
||||||
|
@ -126,8 +126,8 @@ defmodule OpentelemetryOban do
|
||||||
end
|
end
|
||||||
|
|
||||||
defp attributes_before_insert(changeset) do
|
defp attributes_before_insert(changeset) do
|
||||||
queue = Changeset.get_field(changeset, :queue, "unknown")
|
queue = Changeset.get_field(changeset, :queue)
|
||||||
worker = Changeset.get_field(changeset, :worker, "unknown")
|
worker = Changeset.get_field(changeset, :worker)
|
||||||
|
|
||||||
%{
|
%{
|
||||||
Trace.messaging_system() => :oban,
|
Trace.messaging_system() => :oban,
|
||||||
|
|
Loading…
Reference in New Issue