From 91dcb1e2854854d557985843b62d4a9bd97d0fb1 Mon Sep 17 00:00:00 2001 From: Jeff Browning Date: Mon, 14 Nov 2016 17:54:12 -0500 Subject: [PATCH] Scope the title tag selector to the head element --- lib/readability/title_finder.ex | 2 +- test/readability/title_finder_test.exs | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/readability/title_finder.ex b/lib/readability/title_finder.ex index ca4d970..bf7243b 100644 --- a/lib/readability/title_finder.ex +++ b/lib/readability/title_finder.ex @@ -33,7 +33,7 @@ defmodule Readability.TitleFinder do @spec tag_title(html_tree) :: binary def tag_title(html_tree) do html_tree - |> Floki.find("title") + |> Floki.find("head title") |> clean_title() |> String.split(@title_suffix) |> hd() diff --git a/test/readability/title_finder_test.exs b/test/readability/title_finder_test.exs index 7201221..301ce1f 100644 --- a/test/readability/title_finder_test.exs +++ b/test/readability/title_finder_test.exs @@ -71,6 +71,19 @@ defmodule Readability.TitleFinderTest do """ title = Readability.TitleFinder.tag_title(html) assert title == "Tag title-tag-title" + + html = """ + + + Tag title + + + SVG title + + + """ + title = Readability.TitleFinder.tag_title(html) + assert title == "Tag title" end test "extract h1 tag title" do