shadowfacts
/
readability
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Clean up and fix warnings

This commit is contained in:
Jeff Browning 2016-11-04 14:49:42 -04:00
parent 747e0495ed
commit 2f8e84eb8a
1 changed files with 19 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
lib/readability/title_finder.ex
View File

@ -13,19 +13,18 @@ defmodule Readability.TitleFinder do
""" """
@spec title(html_tree) :: binary @spec title(html_tree) :: binary
def title(html_tree) do def title(html_tree) do
maybe_title = og_title(html_tree) case og_title(html_tree) do
if String.length(String.strip(maybe_title)) == 0 do "" ->
maybe_title = tag_title(html_tree) title = tag_title(html_tree)
end
unless good_title?(maybe_title) do if good_title?(title) do
h_title = h_tag_title(html_tree) title
if good_title?(h_title) do else
maybe_title = h_title h_tag_title(html_tree)
end end
title when is_binary(title) ->
title
end end
maybe_title
end end
@doc """ @doc """
@ -35,7 +34,7 @@ defmodule Readability.TitleFinder do
def tag_title(html_tree) do def tag_title(html_tree) do
html_tree html_tree
|> Floki.find("title") |> Floki.find("title")
|> clean_title |> clean_title()
end end
@doc """ @doc """
@ -46,7 +45,7 @@ defmodule Readability.TitleFinder do
html_tree html_tree
|> Floki.find("meta[property=og:title]") |> Floki.find("meta[property=og:title]")
|> Floki.attribute("content") |> Floki.attribute("content")
|> clean_title |> clean_title()
end end
@doc """ @doc """
@ -56,16 +55,16 @@ defmodule Readability.TitleFinder do
def h_tag_title(html_tree, selector \\ @h_tag_selector) do def h_tag_title(html_tree, selector \\ @h_tag_selector) do
html_tree html_tree
|> Floki.find(selector) |> Floki.find(selector)
|> hd |> hd()
|> clean_title |> clean_title()
end end
defp clean_title(html_tree) do defp clean_title(html_tree) do
title_text = html_tree html_tree
|> Floki.text |> Floki.text()
|> String.split(@title_suffix) |> String.split(@title_suffix)
|> hd |> hd()
|> String.strip |> String.strip()
end end
defp good_title?(title) do defp good_title?(title) do