From a1c6a34f5492f14e5a41ec8387dc8ed717f5fe06 Mon Sep 17 00:00:00 2001
From: Shadowfacts <me@shadowfacts.net>
Date: Sat, 27 Jul 2019 21:34:20 -0400
Subject: [PATCH] Preferences Picker titles

---
 Tusker/Screens/Preferences/AdvancedPrefsView.swift | 3 ++-
 Tusker/Screens/Preferences/BehaviorPrefsView.swift | 3 ++-
 Tusker/Screens/Preferences/SilentActionPrefs.swift | 5 ++++-
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/Tusker/Screens/Preferences/AdvancedPrefsView.swift b/Tusker/Screens/Preferences/AdvancedPrefsView.swift
index 9cbf3dff18..b948c631b9 100644
--- a/Tusker/Screens/Preferences/AdvancedPrefsView.swift
+++ b/Tusker/Screens/Preferences/AdvancedPrefsView.swift
@@ -17,7 +17,8 @@ struct AdvancedPrefsView : View {
                 Picker(selection: _statusContentType.binding, label: Text("Post Content Type")) {
                     ForEach(StatusContentType.allCases, id: \.self) { type in
                         Text(type.displayName).tag(type)
-                    }
+                    }//.navigationBarTitle("Post Content Type")
+                    // see FB6838291
                 }
             }
             
diff --git a/Tusker/Screens/Preferences/BehaviorPrefsView.swift b/Tusker/Screens/Preferences/BehaviorPrefsView.swift
index 02b090353b..7fcb1c9e50 100644
--- a/Tusker/Screens/Preferences/BehaviorPrefsView.swift
+++ b/Tusker/Screens/Preferences/BehaviorPrefsView.swift
@@ -23,7 +23,8 @@ struct BehaviorPrefsView : View {
                             Text(visibility.displayName)
                         }
                             .tag(visibility)
-                    }
+                    }//.navigationBarTitle("Default Post Visibility")
+                    // navbar title on the ForEach is currently incorrectly applied when the picker is not expanded, see FB6838291
                 }
                 Toggle(isOn: _automaticallySaveDrafts.binding) {
                     Text("Automatically Save Drafts")
diff --git a/Tusker/Screens/Preferences/SilentActionPrefs.swift b/Tusker/Screens/Preferences/SilentActionPrefs.swift
index e917ac4e38..ccda62a415 100644
--- a/Tusker/Screens/Preferences/SilentActionPrefs.swift
+++ b/Tusker/Screens/Preferences/SilentActionPrefs.swift
@@ -36,7 +36,10 @@ struct SilentActionPrefs : View {
     var body: some View {
         List(Array(preferences.silentActions.keys), id: \.self) { source in
             SilentActionPermissionCell(source: source)
-        }.listStyle(.grouped)
+        }
+            .listStyle(.grouped)
+//            .navigationBarTitle("Silent Action Permissions")
+        // see FB6838291
 //        List(Array(silentActions.keys).identified(by: \.self)) { application in
 //            Text(application)
 ////            Toggle(isOn: Binding(getValue: { self.silentActions[application] == .accepted }, setValue: { self.silentActions[application] = $0 ? .accepted : .rejected }), label: Text(application))