shadowfacts
/
Tusker
2
10
Fork 2
Code Issues 68 Pull Requests Releases Wiki Activity

Don't use prepareThumbnail in Compose screen 

Fixes crash when sharing certain images to share sheet extension
This commit is contained in:
Shadowfacts 2023-05-13 12:38:51 -04:00
parent a9a9bfebeb
commit ae8191ca0e
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Packages/ComposeUI/Sources/ComposeUI/Controllers/AttachmentThumbnailController.swift
View File

@ -95,19 +95,21 @@ class AttachmentThumbnailController: ViewController {
self.gifController = GIFController(gifData: data) self.gifController = GIFController(gifData: data)
} else if type.conforms(to: .image), } else if type.conforms(to: .image),
let image = UIImage(data: data) { let image = UIImage(data: data) {
if fullSize { // using prepareThumbnail on images from PHPicker results in extremely high memory usage,
// crashing share extension. see FB12186346
// if fullSize {
image.prepareForDisplay { prepared in image.prepareForDisplay { prepared in
DispatchQueue.main.async { DispatchQueue.main.async {
self.image = prepared self.image = image
} }
} }
} else { // } else {
image.prepareThumbnail(of: CGSize(width: 80, height: 80)) { prepared in // image.prepareThumbnail(of: CGSize(width: 80, height: 80)) { prepared in
DispatchQueue.main.async { // DispatchQueue.main.async {
self.image = prepared // self.image = prepared
} // }
} // }
} // }
} }
} }
} }