shadowfacts
/
Tusker
2
10
Fork 2
Code Issues 62 Pull Requests Releases Wiki Activity

Xcode recommendations, use AnyObject instead of class in protocol requirements

This commit is contained in:
Shadowfacts 2021-05-22 13:42:53 -04:00
parent b51c1c03cb
commit ffe6450b26
Signed by: shadowfacts
GPG Key ID: 94A5AB95422746E5
20 changed files with 22 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Tusker.xcodeproj/project.pbxproj
View File

@ -1703,7 +1703,7 @@
isa = PBXProject; isa = PBXProject;
attributes = { attributes = {
LastSwiftUpdateCheck = 1200; LastSwiftUpdateCheck = 1200;
LastUpgradeCheck = 1020; LastUpgradeCheck = 1250;
ORGANIZATIONNAME = Shadowfacts; ORGANIZATIONNAME = Shadowfacts;
TargetAttributes = { TargetAttributes = {
D61099AA2144B0CC00432DC2 = { D61099AA2144B0CC00432DC2 = {
@ -2346,6 +2346,7 @@
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES; CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES; CLANG_WARN_SUSPICIOUS_MOVE = YES;
@ -2408,6 +2409,7 @@
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES; CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES; CLANG_WARN_SUSPICIOUS_MOVE = YES;

6
Tusker.xcodeproj/xcshareddata/xcschemes/Pachyderm.xcscheme
View File

@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<Scheme <Scheme
LastUpgradeVersion = "1020" LastUpgradeVersion = "1250"
version = "1.3"> version = "1.3">
<BuildAction <BuildAction
parallelizeBuildables = "YES" parallelizeBuildables = "YES"
@ -29,8 +29,6 @@
shouldUseLaunchSchemeArgsEnv = "YES"> shouldUseLaunchSchemeArgsEnv = "YES">
<Testables> <Testables>
</Testables> </Testables>
<AdditionalOptions>
</AdditionalOptions>
</TestAction> </TestAction>
<LaunchAction <LaunchAction
buildConfiguration = "Debug" buildConfiguration = "Debug"
@ -51,8 +49,6 @@
ReferencedContainer = "container:Tusker.xcodeproj"> ReferencedContainer = "container:Tusker.xcodeproj">
</BuildableReference> </BuildableReference>
</MacroExpansion> </MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
</LaunchAction> </LaunchAction>
<ProfileAction <ProfileAction
buildConfiguration = "Release" buildConfiguration = "Release"

2
Tusker.xcodeproj/xcshareddata/xcschemes/Tusker.xcscheme
View File

@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<Scheme <Scheme
LastUpgradeVersion = "1020" LastUpgradeVersion = "1250"
version = "1.7"> version = "1.7">
<BuildAction <BuildAction
parallelizeBuildables = "YES" parallelizeBuildables = "YES"

2
Tusker/Screens/Asset Picker/AssetCollectionViewController.swift
View File

@ -12,7 +12,7 @@ import Photos
private let reuseIdentifier = "assetCell" private let reuseIdentifier = "assetCell"
private let cameraReuseIdentifier = "showCameraCell" private let cameraReuseIdentifier = "showCameraCell"
protocol AssetCollectionViewControllerDelegate: class { protocol AssetCollectionViewControllerDelegate: AnyObject {
func shouldSelectAsset(_ asset: PHAsset) -> Bool func shouldSelectAsset(_ asset: PHAsset) -> Bool
func didSelectAssets(_ assets: [PHAsset]) func didSelectAssets(_ assets: [PHAsset])
func captureFromCamera() func captureFromCamera()

2
Tusker/Screens/Asset Picker/AssetPickerViewController.swift
View File

@ -9,7 +9,7 @@
import UIKit import UIKit
import Photos import Photos
protocol AssetPickerViewControllerDelegate: class { protocol AssetPickerViewControllerDelegate: AnyObject {
func assetPicker(_ assetPicker: AssetPickerViewController, shouldAllowAssetOfType type: CompositionAttachmentData.AttachmentType) -> Bool func assetPicker(_ assetPicker: AssetPickerViewController, shouldAllowAssetOfType type: CompositionAttachmentData.AttachmentType) -> Bool
func assetPicker(_ assetPicker: AssetPickerViewController, didSelectAttachments attachments: [CompositionAttachmentData]) func assetPicker(_ assetPicker: AssetPickerViewController, didSelectAttachments attachments: [CompositionAttachmentData])
} }

2
Tusker/Screens/Compose/ComposeDrawingViewController.swift
View File

@ -9,7 +9,7 @@
import UIKit import UIKit
import PencilKit import PencilKit
protocol ComposeDrawingViewControllerDelegate: class { protocol ComposeDrawingViewControllerDelegate: AnyObject {
func composeDrawingViewControllerClose(_ drawingController: ComposeDrawingViewController) func composeDrawingViewControllerClose(_ drawingController: ComposeDrawingViewController)
func composeDrawingViewController(_ drawingController: ComposeDrawingViewController, saveDrawing drawing: PKDrawing) func composeDrawingViewController(_ drawingController: ComposeDrawingViewController, saveDrawing drawing: PKDrawing)
} }

2
Tusker/Screens/Compose/ComposeHostingController.swift
View File

@ -11,7 +11,7 @@ import Combine
import Pachyderm import Pachyderm
import PencilKit import PencilKit
protocol ComposeHostingControllerDelegate: class { protocol ComposeHostingControllerDelegate: AnyObject {
func dismissCompose(mode: ComposeUIState.DismissMode) -> Bool func dismissCompose(mode: ComposeUIState.DismissMode) -> Bool
} }

2
Tusker/Screens/Compose/ComposeTextViewCaretScrolling.swift
View File

@ -8,7 +8,7 @@
import UIKit import UIKit
protocol ComposeTextViewCaretScrolling: class { protocol ComposeTextViewCaretScrolling: AnyObject {
var caretScrollPositionAnimator: UIViewPropertyAnimator? { get set } var caretScrollPositionAnimator: UIViewPropertyAnimator? { get set }
} }

4
Tusker/Screens/Compose/ComposeUIState.swift
View File

@ -8,7 +8,7 @@
import SwiftUI import SwiftUI
protocol ComposeUIStateDelegate: class { protocol ComposeUIStateDelegate: AnyObject {
var assetPickerDelegate: AssetPickerViewControllerDelegate? { get } var assetPickerDelegate: AssetPickerViewControllerDelegate? { get }
func dismissCompose(mode: ComposeUIState.DismissMode) func dismissCompose(mode: ComposeUIState.DismissMode)
@ -60,6 +60,6 @@ extension ComposeUIState {
} }
} }
protocol ComposeAutocompleteHandler: class { protocol ComposeAutocompleteHandler: AnyObject {
func autocomplete(with string: String) func autocomplete(with string: String)
} }

2
Tusker/Screens/Compose/EmojiPickerCollectionViewController.swift
View File

@ -11,7 +11,7 @@ import Pachyderm
private let reuseIdentifier = "EmojiCell" private let reuseIdentifier = "EmojiCell"
protocol EmojiPickerCollectionViewControllerDelegate: class { protocol EmojiPickerCollectionViewControllerDelegate: AnyObject {
func selectedEmoji(_ emoji: Emoji) func selectedEmoji(_ emoji: Emoji)
} }

2
Tusker/Screens/Drafts/DraftsTableViewController.swift
View File

@ -8,7 +8,7 @@
import UIKit import UIKit
protocol DraftsTableViewControllerDelegate: class { protocol DraftsTableViewControllerDelegate: AnyObject {
func draftSelectionCanceled() func draftSelectionCanceled()
func shouldSelectDraft(_ draft: Draft, completion: @escaping (Bool) -> Void) func shouldSelectDraft(_ draft: Draft, completion: @escaping (Bool) -> Void)
func draftSelected(_ draft: Draft) func draftSelected(_ draft: Draft)

2
Tusker/Screens/Fast Account Switcher/FastAccountSwitcherViewController.swift
View File

@ -8,7 +8,7 @@
import UIKit import UIKit
protocol FastAccountSwitcherViewControllerDelegate: class { protocol FastAccountSwitcherViewControllerDelegate: AnyObject {
func fastAccountSwitcher(_ fastAccountSwitcher: FastAccountSwitcherViewController, triggerZoneContains point: CGPoint) -> Bool func fastAccountSwitcher(_ fastAccountSwitcher: FastAccountSwitcherViewController, triggerZoneContains point: CGPoint) -> Bool
} }

2
Tusker/Screens/Main/MainSidebarViewController.swift
View File

@ -9,7 +9,7 @@
import UIKit import UIKit
import Pachyderm import Pachyderm
protocol MainSidebarViewControllerDelegate: class { protocol MainSidebarViewControllerDelegate: AnyObject {
func sidebarRequestPresentCompose(_ sidebarViewController: MainSidebarViewController) func sidebarRequestPresentCompose(_ sidebarViewController: MainSidebarViewController)
func sidebar(_ sidebarViewController: MainSidebarViewController, didSelectItem item: MainSidebarViewController.Item) func sidebar(_ sidebarViewController: MainSidebarViewController, didSelectItem item: MainSidebarViewController.Item)
} }

1
Tusker/Screens/Main/MainTabBarViewController.swift
View File

@ -7,7 +7,6 @@
// //
import UIKit import UIKit
import SwiftUI
class MainTabBarViewController: UITabBarController, UITabBarControllerDelegate { class MainTabBarViewController: UITabBarController, UITabBarControllerDelegate {

2
Tusker/Screens/Onboarding/InstanceSelectorTableViewController.swift
View File

@ -10,7 +10,7 @@ import UIKit
import Combine import Combine
import Pachyderm import Pachyderm
protocol InstanceSelectorTableViewControllerDelegate: class { protocol InstanceSelectorTableViewControllerDelegate: AnyObject {
func didSelectInstance(url: URL) func didSelectInstance(url: URL)
} }

2
Tusker/Screens/Search/SearchResultsViewController.swift
View File

@ -14,7 +14,7 @@ fileprivate let accountCell = "accountCell"
fileprivate let statusCell = "statusCell" fileprivate let statusCell = "statusCell"
fileprivate let hashtagCell = "hashtagCell" fileprivate let hashtagCell = "hashtagCell"
protocol SearchResultsViewControllerDelegate: class { protocol SearchResultsViewControllerDelegate: AnyObject {
func selectedSearchResult(account accountID: String) func selectedSearchResult(account accountID: String)
func selectedSearchResult(hashtag: Hashtag) func selectedSearchResult(hashtag: Hashtag)
func selectedSearchResult(status statusID: String) func selectedSearchResult(status statusID: String)

2
Tusker/Screens/Timeline/InstanceTimelineViewController.swift
View File

@ -8,7 +8,7 @@
import UIKit import UIKit
protocol InstanceTimelineViewControllerDelegate: class { protocol InstanceTimelineViewControllerDelegate: AnyObject {
func didSaveInstance(url: URL) func didSaveInstance(url: URL)
func didUnsaveInstance(url: URL) func didUnsaveInstance(url: URL)
} }

2
Tusker/Screens/Utilities/Previewing.swift
View File

@ -10,7 +10,7 @@ import UIKit
import SafariServices import SafariServices
import Pachyderm import Pachyderm
protocol MenuPreviewProvider: class { protocol MenuPreviewProvider: AnyObject {
typealias PreviewProviders = (content: UIContextMenuContentPreviewProvider, actions: () -> [UIMenuElement]) typealias PreviewProviders = (content: UIContextMenuContentPreviewProvider, actions: () -> [UIMenuElement])

2
Tusker/Views/Attachments/AttachmentView.swift
View File

@ -11,7 +11,7 @@ import Pachyderm
import Gifu import Gifu
import AVFoundation import AVFoundation
protocol AttachmentViewDelegate: class { protocol AttachmentViewDelegate: AnyObject {
func attachmentViewGallery(startingAt index: Int) -> GalleryViewController? func attachmentViewGallery(startingAt index: Int) -> GalleryViewController?
func attachmentViewPresent(_ vc: UIViewController, animated: Bool) func attachmentViewPresent(_ vc: UIViewController, animated: Bool)
} }

2
Tusker/Views/BaseEmojiLabel.swift
View File

@ -11,7 +11,7 @@ import Pachyderm
private let emojiRegex = try! NSRegularExpression(pattern: ":(\\w+):", options: []) private let emojiRegex = try! NSRegularExpression(pattern: ":(\\w+):", options: [])
protocol BaseEmojiLabel: class { protocol BaseEmojiLabel: AnyObject {
var emojiIdentifier: String? { get set } var emojiIdentifier: String? { get set }
var emojiRequests: [ImageCache.Request] { get set } var emojiRequests: [ImageCache.Request] { get set }
var emojiFont: UIFont { get } var emojiFont: UIFont { get }