shadowfacts
/
Tusker
2
10
Fork 2
Code Issues 62 Pull Requests Releases Wiki Activity

xcconfig Fixes #340

Merged
shadowfacts merged 1 commits from Fahim/Tusker:Fahim/xcconfig into develop 2023-01-25 14:55:51 +00:00
Conversation 3 Commits 1 Files Changed 2 +8 -17
Fahim commented 2023-01-25 05:56:09 +00:00
Contributor
Copy Link
  • Ensure that all bundle prefixes are replaced correctly for all targets and in entitlements files too
* Ensure that all bundle prefixes are replaced correctly for all targets and in entitlements files too
Fahim added 1 commit 2023-01-25 05:56:09 +00:00
507d9c23e7 xcconfig Fixes 
* Ensure that all bundle prefixes are replaced correctly for all targets and in entitlements files too
shadowfacts commented 2023-01-25 14:42:13 +00:00
Owner
Copy Link

Thanks for the PR!

Have you tested this? I was under the impression that env vars/build settings aren't substituted in entitlements files.

Thanks for the PR! Have you tested this? I was under the impression that env vars/build settings aren't substituted in entitlements files.
Fahim commented 2023-01-25 14:45:32 +00:00
Author
Contributor
Copy Link

The builds I've created with the change work fine. I have not submitted anything to Apple with this particular type of change though ... However, I do have the same changes used to notariaze a macOS app. Again, I do realize it's not the same thing ...

The builds I've created with the change work fine. I have not submitted anything to Apple with this particular type of change though ... However, I do have the same changes used to notariaze a macOS app. Again, I do realize it's not the same thing ...
shadowfacts merged commit 507d9c23e7 into develop 2023-01-25 14:55:51 +00:00
shadowfacts commented 2023-01-25 14:56:11 +00:00
Owner
Copy Link

It does indeed seem to work in my testing as well. Thanks for your contribution!

It does indeed seem to work in my testing as well. Thanks for your contribution!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
external

Issue depends on changes to external projects.

  
help wanted

Need some help

  
invalid

Something is wrong

  
investigate

An unconfirmed issue

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
external
help wanted
invalid
investigate
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: shadowfacts/Tusker#340
No description provided.
Delete Branch "Fahim/Tusker:Fahim/xcconfig"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?