shadowfacts
/
Tusker
2
10
Fork 2
Code Issues 62 Pull Requests Releases Wiki Activity

Fahim/cw-filter #342

Closed
Fahim wants to merge 3 commits from Fahim:Fahim/cw-filter into develop
pull from: Fahim:Fahim/cw-filter
merge into: shadowfacts:develop
Conversation 1 Commits 3 Files Changed 10 +114 -107
Fahim commented 2023-01-25 15:15:09 +00:00
Contributor
Copy Link
  • Replaced the collapsible button used in both collection view cell instances and table view cell instances with a single custom view which also displays a reason for the cell being collapsed
* Replaced the collapsible button used in both collection view cell instances and table view cell instances with a single custom view which also displays a reason for the cell being collapsed
Fahim added 3 commits 2023-01-25 15:15:10 +00:00
e68100eb71 Duckable Issue 
* IF you have the .testTarget enabled, on Xcode 14.2 you get an error about the test target source needing to be under the "Tests" folder or something similar
ea30b9866d Collapsible Cells 
* Change the look of the collapsible cell
* Add a reason to the collapsed cell
80f21cb2f1 Collapsible Table Cells 
* Fix the table cell instances to use the new collapsible button
* Add accessibility label to StatusCollapseButton and change button to allow setting action
shadowfacts commented 2023-01-26 05:03:15 +00:00
Owner
Copy Link

I have a different plan for how posts collapsed due to their length will be indicated differently from regular CW'd ones, so I'm going to close this. Nonetheless, thanks for your PR!

I have a different plan for how posts collapsed due to their length will be indicated differently from regular CW'd ones, so I'm going to close this. Nonetheless, thanks for your PR!
shadowfacts closed this pull request 2023-01-26 05:03:15 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
external

Issue depends on changes to external projects.

  
help wanted

Need some help

  
invalid

Something is wrong

  
investigate

An unconfirmed issue

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
external
help wanted
invalid
investigate
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: shadowfacts/Tusker#342
No description provided.
Delete Branch "Fahim:Fahim/cw-filter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?