3906 Commits

Author SHA1 Message Date
Miguel Sousa
a60113dff6 [ttx] Remove FFIL test
It’s not worth the effort 1c2a531de2 (commitcomment-21516461)
2017-03-28 03:43:01 -07:00
Miguel Sousa
ddf9f2334b [ttx] unnecessary lower()
Valid XML files always start with a lowercase declaration
187b886fde (commitcomment-21508520)
2017-03-28 03:43:01 -07:00
Miguel Sousa
fefe5d5c46 [ttx] Strip the BOM only in XML files 2017-03-28 03:43:01 -07:00
Miguel Sousa
1a58912a60 [ttx] Tests 2017-03-28 03:43:01 -07:00
Miguel Sousa
076e2ba33a [ttx] Close file before returning, to prevent ResourceWarnings in py3 2017-03-28 03:43:01 -07:00
Miguel Sousa
4fce7a0b7b [ttx] Strip BOM from beginning of file
Fixes #896
2017-03-28 03:43:01 -07:00
Miguel Sousa
9adf3d8aca Update NEWS 2017-03-23 17:12:31 -07:00
Miguel Sousa
5e115c1d2a [CFF2] Report the correct number of regions in the font
This change also makes the processing of the blend operator to be as described at https://www.microsoft.com/typography/otspec/cff2charstr.htm#section4.5
2017-03-23 17:12:31 -07:00
Cosimo Lupo
6ac3523d74
[_TTGlyphSet] fetch height and tsb from vmtx if available
The width and lsb from hmtx are already there

Fixes #893

https://github.com/fonttools/fonttools/pull/880#issuecomment-288558012
2017-03-23 12:51:16 +00:00
Behdad Esfahbod
1f372cc8ed [merge] Add TODO item re merging duplicate items 2017-03-22 15:03:52 -07:00
Cosimo Lupo
21944d3cc8
Bump version: 3.9.1 → 3.9.2.dev0 2017-03-20 09:59:58 +00:00
Cosimo Lupo
524db89b69
Release 3.9.1 2017-03-20 09:59:07 +00:00
Cosimo Lupo
20b02c8a6f
Update changelog 2017-03-20 09:58:46 +00:00
Behdad Esfahbod
9798c30d57 [varLib.merger] Really recombine multiple PairPosFormat2 subtables...
Fixup for 49d311550c29f7501dd4bc91cb24074e3d607b77

Previous try was completely dropping the ParPosFormat2 subtables. Ouch!

Fixes https://github.com/fonttools/fonttools/issues/888
2017-03-17 20:30:56 -07:00
Miguel Sousa
e2d4fe9da8 minor 2017-03-17 07:48:22 -07:00
Miguel Sousa
4de5af36cb Add usage example of RecordingPen 2017-03-17 02:19:12 -07:00
Behdad Esfahbod
49d311550c [varLib.merger] Recombine multiple PairPosFormat2 subtables...
...if they were split because of offset overflows.

Fixes https://github.com/fonttools/fonttools/issues/888
for most common cases.
2017-03-16 17:51:59 -07:00
Behdad Esfahbod
92cb5d28d6 [varLib.merger] Shuffle _ClassDef_invert for more uses 2017-03-16 17:46:28 -07:00
Behdad Esfahbod
7f83d6d445 [varLib.merger] Add TODO item 2017-03-16 16:18:27 -07:00
Behdad Esfahbod
0f5a46b1f9 [varLib.merger] Only insert PairPosFormat1 if non-empty
This is proper fix for c8b2088162f1542dd29b2d370aa2a2c081452559
2017-03-16 16:15:10 -07:00
Behdad Esfahbod
c8b2088162 Revert "[varLib.merger] only insert merged PairPosFormat1 subtable if at least one font has one"
This reverts commit d83c2fb2090fa58f94fdf32d1aa2d2d8665cec05.

This is wrong. We should insert if and only iff there's at least one of the
fonts with a Format1. Yours doesn't look at all fonts. Since this one is not a
bugfix but improvement, I'll fix it separately.
2017-03-16 16:07:46 -07:00
Behdad Esfahbod
a2b23811a2 Merge pull request #887 from fonttools/class-kern-merge
[varLib.merger] Fix interpolating PairPos Format 2
2017-03-16 16:03:34 -07:00
Miguel Sousa
6ba428eaf7 [varLib.interpolatable test] OTF example 2017-03-15 23:14:21 -07:00
Cosimo Lupo
23511fd302
[varLib.merger] set ClassDef{1,2}.Format using same logic as otTables.ClassDef.preWrite 2017-03-14 16:14:08 +00:00
Cosimo Lupo
e6125b353e
[varLib.merger] avoid reusing the same Class2Record (mutable) objects
Class2Record is mutable, hence doing `[rec2] * l.Class2Count` produces a list containing multiple references to the same instance. When later on we do the interpolation, modifying one would modify them all.
We need to instantiate distinct objects.

See 6f41c2ab53 (commitcomment-21310803)
2017-03-14 14:46:17 +00:00
Cosimo Lupo
d83c2fb209
[varLib.merger] only insert merged PairPosFormat1 subtable if at least one font has one 2017-03-14 14:29:10 +00:00
Cosimo Lupo
aad0d46069
[varLib.merger] fix IndexError with empty ClassDef1 in PairPosFormat2
https://github.com/fonttools/fonttools/pull/881#issue-213020690
2017-03-14 14:26:55 +00:00
justvanrossum
b05f2039b5 added missing import 2017-03-14 12:00:13 +01:00
Cosimo Lupo
af7ff9a8fd
fix "InterpolateLayoutGPOS_2_class_diff2.ttx" expected test result
6f41c2ab53 (commitcomment-21293526)
2017-03-13 17:20:28 +00:00
Miguel Sousa
6f41c2ab53 [varLib.interpolate_layout] Fix GPOS LookupType 2 class pairs test results 2017-03-13 06:51:54 -07:00
Miguel Sousa
0cc4ea85c6 [varLib.interpolate_layout] Tests for GPOS LookupType 2 class pairs 2017-03-13 06:51:54 -07:00
Cosimo Lupo
ffb68042dc
Bump version: 3.9.0 → 3.9.1.dev0 2017-03-13 13:36:38 +00:00
Cosimo Lupo
7dc69f2ae2
Release 3.9.0 2017-03-13 13:35:18 +00:00
Cosimo Lupo
e6f39f855c
[tables_test] minor: fix docstrings 2017-03-13 11:28:39 +00:00
Cosimo Lupo
6f5a4f8365 Merge pull request #885 from miguelsousa/cff2-patch
[CFF2] Support ‘maxstack’
2017-03-13 09:33:19 +00:00
Cosimo Lupo
3ef287efee
Update changelog 2017-03-13 09:25:14 +00:00
Miguel Sousa
bba1d9f225 [CFF2] Support ‘maxstack’ 2017-03-13 00:02:13 -07:00
Cosimo Lupo
35b9efe648
[varLib.builder_test] added unit tests for buildVarData
b2825ff6b3 (commitcomment-21256990)

Note that the "Tests/varLib/__init__.py" file is necessary so that pytest can distinguish between same-named test modules (e.g. we have another "builder_test.py" file in Tests/feaLib).
2017-03-10 16:01:07 +00:00
Cosimo Lupo
b2825ff6b3
[varLib.builder] fix calculation of VarData.NumShorts
The problem was that `break` statement: we stopped searching for SHORT columns in each delta set after finding the first, but rows can contain more than one in any order.

Fixes https://github.com/googlei18n/fontmake/issues/271
2017-03-10 12:39:06 +00:00
Sascha Brawer
989270afc5 [AAT] Use ☃ instead of 🌍 to test non-ASCII characters
On some Python builds, Unicode characters above U+FFFF get escaped
to two question marks ?? instead of just one ?. This is not a real
problem, but for testing it is a nuisance when the results depend
on the platform.
2017-03-10 20:20:22 +08:00
Sascha Brawer
ea1adf42a7 [AAT] Add Char64 converter for 64-byte ASCII character strings
Used by Apple Advanced Typography tables, for example `gcid`.
https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6gcid.html

https://github.com/fonttools/fonttools/issues/178
2017-03-10 20:20:22 +08:00
Miguel Sousa
64d5119642 whitespace 2017-03-09 21:30:28 -08:00
Sascha Brawer
d7a298f36d [otConverters] Add unit test for otConverters.UInt8
This class had been added in the `morx` branch, and I wanted
to merge it into master. While writing tests for it, I noticed
that `otConverters` has meanwhile been extended by an `UInt8`
converter. Therefore, only adding a test for the existing
implementation.
2017-03-09 20:52:26 +01:00
Sascha Brawer
910edb47df [otConverters] Add unit test for otConverters.Long
I've got some changes in the `morx` branch which I'd like to merge
into master.  So I'm writing this unit test as an example how to
test `otConverter` code.
2017-03-09 20:41:34 +01:00
Cosimo Lupo
f662391091 Merge pull request #883 from anthrotype/fix-empty-cff-delta
[cffLib/psCharStrings] fix IndexError with empty deltas
2017-03-09 19:39:54 +00:00
Sascha Brawer
189c722626 [feaLib] Clean up syntax tree for FeatureNames
The syntax tree representation now reflects the syntax of feature files.
Before this change, FeatureNames did not have their own `ast.Block`,
which had made the code quite messy.
2017-03-10 02:48:32 +08:00
Cosimo Lupo
2e46476671
[cffLib] fix IndexError when dumping toXML empty deltas
$ ttx -t CFF "font.otf"
Dumping "font.otf" to "font.ttx"...
Dumping 'CFF ' table...
ERROR: Unhandled exception has occurred
Traceback (most recent call last):
  File "fonttools/Lib/fontTools/ttx.py", line 384, in main
    process(jobs, options)
  File "fonttools/Lib/fontTools/ttx.py", line 358, in process
    action(input, output, options)
  File "fonttools/Lib/fontTools/misc/loggingTools.py", line 372, in wrapper
    return func(*args, **kwds)
  File "fonttools/Lib/fontTools/ttx.py", line 258, in ttDump
    newlinestr=options.newlinestr)
  File "fonttools/Lib/fontTools/ttLib/__init__.py", line 311, in saveXML
    self._tableToXML(tableWriter, tag, progress)
  File "fonttools/Lib/fontTools/ttLib/__init__.py", line 348, in _tableToXML
    table.toXML(writer, self, progress)
  File "fonttools/Lib/fontTools/ttLib/tables/C_F_F_.py", line 42, in toXML
    self.cff.toXML(writer, progress)
  File "fonttools/Lib/fontTools/cffLib.py", line 135, in toXML
    font.toXML(xmlWriter, progress)
  File "fonttools/Lib/fontTools/cffLib.py", line 2178, in toXML
    BaseDict.toXML(self, xmlWriter, progress)
  File "fonttools/Lib/fontTools/cffLib.py", line 2128, in toXML
    conv.xmlWrite(xmlWriter, name, value, progress)
  File "fonttools/Lib/fontTools/cffLib.py", line 1120, in xmlWrite
    value.toXML(xmlWriter, progress)
  File "fonttools/Lib/fontTools/cffLib.py", line 2128, in toXML
    conv.xmlWrite(xmlWriter, name, value, progress)
  File "fonttools/Lib/fontTools/cffLib.py", line 1089, in xmlWrite
    if isinstance(value[0], list):
IndexError: list index out of range
2017-03-09 15:40:52 +00:00
Cosimo Lupo
33b42f47b6
[cffLib/psCharStrings] fix IndexError with empty deltas
After 2b2aca1, DictCompiler/Decompiler's `arg_delta` method unconditionally attempts to get the first item to check if it's a list, but this fails with `IndexError` when the value is empty.

```
Traceback (most recent call last):
  [...]
  File "/Users/cosimolupo/Documents/Github/ufo2ft/Lib/ufo2ft/otfPostProcessor.py", line 15, in __init__
    otf.save(stream)
  File "/Users/cosimolupo/Documents/Github/fonttools/Lib/fontTools/ttLib/__init__.py", line 219, in save
    self._writeTable(tag, writer, done)
  File "/Users/cosimolupo/Documents/Github/fonttools/Lib/fontTools/ttLib/__init__.py", line 658, in _writeTable
    tabledata = self.getTableData(tag)
  File "/Users/cosimolupo/Documents/Github/fonttools/Lib/fontTools/ttLib/__init__.py", line 669, in getTableData
    return self.tables[tag].compile(self)
  File "/Users/cosimolupo/Documents/Github/fonttools/Lib/fontTools/ttLib/tables/C_F_F_.py", line 20, in compile
    self.cff.compile(f, otFont)
  File "/Users/cosimolupo/Documents/Github/fonttools/Lib/fontTools/cffLib.py", line 124, in compile
    writer.toFile(file)
  File "/Users/cosimolupo/Documents/Github/fonttools/Lib/fontTools/cffLib.py", line 300, in toFile
    endPos = pos + item.getDataLength()
  File "/Users/cosimolupo/Documents/Github/fonttools/Lib/fontTools/cffLib.py", line 1858, in getDataLength
    return len(self.compile("getDataLength"))
  File "/Users/cosimolupo/Documents/Github/fonttools/Lib/fontTools/cffLib.py", line 1879, in compile
    data.append(arghandler(value))
  File "/Users/cosimolupo/Documents/Github/fonttools/Lib/fontTools/cffLib.py", line 1910, in arg_delta
    val0 = value[0]
IndexError: list index out of range
``
2017-03-09 14:21:38 +00:00
Sascha Brawer
4210c9d2d6 [feaLib] Clean up lexer test for handling comments
https://github.com/fonttools/fonttools/issues/829
2017-03-09 15:20:21 +01:00
Sascha Brawer
bc0670f53f [feaLib] Simplify parser API by removing the ignore_comments option
https://github.com/fonttools/fonttools/pull/879#discussion_r104947968
https://github.com/fonttools/fonttools/issues/829
2017-03-09 22:17:58 +08:00