6736 Commits

Author SHA1 Message Date
ReadRoberts
ff0716f7b5 Code clean-up of items pointed out in review.
re-named variables from snake-case to camel-case throughout functions, except for 'master_ttfs' (which is ugly when camel-cased, and is the lone snake-cased in other functions) and the function names (which follows the precedent set in almost all of the rest of the module).
2019-03-26 13:54:16 -07:00
ReadRoberts
c06c5c5087 Code clean-up of items pointed out in review.
removed unused dicts
Remove print statement
Rename v_orig_mapping_i to v_orig_mapping. The suffix was left over from an earlier pass, when there was a mapping for the direct store and another one for the indirect store.
2019-03-26 10:45:04 -07:00
ReadRoberts
1fe0348bad Remove old debug pdb.set_trace(). This has already been fixed on another branch that has not yet been merged, but I need to fix it here for the VVAR test to pass. 2019-03-21 10:48:56 -07:00
ReadRoberts
ecf738b964 Add support for building VVAR table from vmtx and VORG tables.
Add test case.
2019-03-21 10:06:47 -07:00
Cosimo Lupo
d2c462a0fb Bump version: 3.39.0 → 3.39.1.dev0 2019-03-19 16:38:33 +00:00
Cosimo Lupo
88a9e718c4 Release 3.39.0 2019-03-19 16:38:33 +00:00
Cosimo Lupo
cc6fce55c7 Update changelog [skip ci] 2019-03-19 16:29:41 +00:00
ReadRoberts
635537604d Fix for subsetting HVAR tables that have an AdvanceWidthMap when the --retain-gid option is used. Needed to make subset_test.py::test_retain_gids_cff2 tests pass. 2019-03-19 16:27:21 +00:00
Cosimo Lupo
1cb9b81861 Update changelog [skip ci] 2019-03-19 15:08:18 +00:00
Just van Rossum
b2f7ea3d1c
Merge pull request #1546 from justvanrossum/fix_issue1545
[ttLib/glyf] Raise more specific error when encountering recursive components. Fixes #1545.
2019-03-18 08:41:12 +01:00
justvanrossum
20c93b9fdb use RecursionError, and provide an alias for RuntimeError for Py2 2019-03-17 18:18:10 +01:00
justvanrossum
12ec7f539e improve error message 2019-03-17 15:35:35 +01:00
justvanrossum
ac2413e905 [ttLib/glyf] raise TTLibError with the offending glyph name in the error message when a component (indirectly) references itself 2019-03-17 15:30:20 +01:00
Nikolaus Waxweiler
5290e831a1 Remove pyftinspect (#1542) 2019-03-15 11:03:20 -07:00
Nikolaus Waxweiler
4921d97d02 Revert "Remove pyftinspect"
This reverts commit d3d550976a7455f16831118446cc431da647e081.

This was an accidental commit.
2019-03-15 15:23:54 +00:00
Nikolaus Waxweiler
d3d550976a Remove pyftinspect 2019-03-15 15:17:51 +00:00
Khaled Hosny
45861a15ca [feaLib] Reject invalid lookupflag without a value
Fixes https://github.com/fonttools/fonttools/issues/1538
2019-03-15 14:13:46 +02:00
Khaled Hosny
250eac4cae [feaLib] Correctly handle lookupflag 0 in asFea()
Part of https://github.com/fonttools/fonttools/issues/1538
2019-03-15 14:13:46 +02:00
Nikolaus Waxweiler
079f68350f [designspaceLib] Document proposed public.skipExportGlyphs lib key (#1534)
* Document proposed public.skipExportGlyphs lib key
2019-03-14 16:06:05 -05:00
Cosimo Lupo
abae80d730 [feaLib] make 'forceChain' an optional kwarg for barkward compat
See discussion at:
https://github.com/fonttools/fonttools/pull/1511#issuecomment-472425283
2019-03-13 15:11:53 +00:00
Cosimo Lupo
242ad6279d [merge] don't drop platformID=0 Unicode cmap subtables
instead treat them as equivalent to platformID=3 Windows Unicode subtables
2019-03-12 13:13:15 +00:00
Cosimo Lupo
2c3c74f108 [merge] support merging vhea table (same as hhea) 2019-03-12 12:26:54 +00:00
Cosimo Lupo
1fd11a3a0a psCharStrings: replace sys.stderr.write with log.warning 2019-03-12 11:43:10 +00:00
Nikolaus Waxweiler
1765e59f86
Merge pull request #1535 from fonttools/designspaceLib-find-bent-master
designspaceLib, findDefault: consider axis mapping
2019-03-11 12:22:38 +00:00
Nikolaus Waxweiler
754c1c6a2f Minor: Remove redundant comment 2019-03-10 23:03:08 +00:00
Nikolaus Waxweiler
5f7afa23b2 newDefaultLocation: Return location in design space 2019-03-10 22:20:00 +00:00
Nikolaus Waxweiler
c4899330c5 designspaceLib, findDefault: consider axis mapping 2019-03-10 22:12:06 +00:00
Cosimo Lupo
9efbb0e74e
Merge pull request #1533 from justvanrossum/license_url
fix embedded license URL in name tables of test fonts
2019-03-06 17:31:51 -08:00
justvanrossum
24b45b6326 fix embedded license URL in name tables of test fonts 2019-03-06 17:20:40 +01:00
Just van Rossum
a6a897db56
Merge pull request #1532 from justvanrossum/issue_urls2
More updated issue URLs.
2019-03-06 17:07:54 +01:00
justvanrossum
7b81ef8de7 more updated issue URLs 2019-03-06 16:53:17 +01:00
justvanrossum
d897a08fc8 more updated issue URLs 2019-03-06 16:52:35 +01:00
justvanrossum
e22453c933 followup to #1531 2019-03-06 16:47:16 +01:00
Just van Rossum
2493332c86
Merge pull request #1531 from justvanrossum/issue_urls
updated inline github issue URLs to current repo location
2019-03-06 16:18:03 +01:00
justvanrossum
723e7a1d3c updated inline github issue URLs 2019-03-06 16:01:28 +01:00
Cosimo Lupo
a72088b65e
Merge pull request #1528 from anthrotype/gvar-vmtx-phantom-pts
varLib: use vmtx to compute vertical phantom points, else fall back to ascent - UPEM
2019-03-05 22:27:29 -08:00
Cosimo Lupo
df3bbbb7ad varLib: use hhea.ascent and head.unitsPerEM for phantom pts when vmtx missing
https://github.com/anthrotype/fonttools/pull/new/gvar-vmtx-phantom-pts
2019-03-05 10:02:35 -08:00
Cosimo Lupo
cf9f866943 varLib: fix expected test results after bottomSideY changed sign 2019-03-04 18:41:43 -08:00
Cosimo Lupo
52ec934a02 varLib: use vmtx to compute phantom pts; fix sign of bottomSideY
when 'vmtx' is present in a font, use that to compute the third and fourth 'phantom points'.
When not present, we use the glyph bbox yMax and yMin coords.

NOTE that previously the bottomSideY was incorrectly set to -glyph.yMin (with a minus sign).
However, the minus is not needed when we use the bbox.
Positive vertical advance grows towards negative Y axis.
2019-03-04 18:33:23 -08:00
Cosimo Lupo
3de9e2978c
Merge pull request #1525 from fonttools/pyup-scheduled-update-2019-03-04
Scheduled weekly dependency update for week 09
2019-03-04 17:03:15 -08:00
Cosimo Lupo
a15f94f0c6
Merge pull request #1527 from anthrotype/tuplevar-ttx-ordered-attrs
TupleVariation.toXML: sort attrs min/value/max in TTX dump
2019-03-04 17:02:08 -08:00
Cosimo Lupo
2dedea5f8f models: remove unused axisOrder argument from _computeMasterSupports private method
it's no longer used in the body of the method. If needed, it's accessible from self.axisOrder
2019-03-04 16:58:15 -08:00
Cosimo Lupo
f8c7950e48 models: minor: explicitly test for axisOrder is None
389cf7c56a (r32585140)
2019-03-04 16:51:53 -08:00
Cosimo Lupo
71e44a52ee TupleVariation.toXML: sort attrs min/value/max in TTX dump
It's more legible if the peak value is written after the min and before the max value
defining a given region.
2019-03-04 16:41:26 -08:00
Cosimo Lupo
694b57754c
Merge pull request #1526 from anthrotype/varLib-models-tests
[varLib.models] minor tests cleanups
2019-03-04 16:34:43 -08:00
Just van Rossum
a360252709
Merge pull request #1523 from justvanrossum/cmap_update2
[cmap,VORG,COLR,otTables] misc idiomatic updates
2019-03-04 21:54:46 +01:00
Cosimo Lupo
c813b65d32 models_test: test default 0.0 input locations are omitted internally 2019-03-04 12:38:32 -08:00
Cosimo Lupo
0811834b3c models_test: VariationModel input locations should be in normalized space
not only base should be at 0, but min/max respectively at -1.0 and +1.0.
that's how varLib constructs models internally, so update test case to reflect that
2019-03-04 12:31:08 -08:00
Cosimo Lupo
05824b8616 VariationModel: assert that locations are unique 2019-03-04 11:42:54 -08:00
Cosimo Lupo
d8152feb21 VariationModels: remove unused lowerBound/upperBound static methods 2019-03-04 11:15:06 -08:00